Skip to content

[Docker] Pin protobuf to 3.20.1 #78369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

[Docker] Pin protobuf to 3.20.1 #78369

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented May 26, 2022

To protect CI from sudden version updates, that are not compatible with other packages

Fixes #78362

@malfet
[Docker] Pin protobuf to 3.20.1
dae2599 
To protect CI from sudden version updates, that are not compatible with other packages

Fixes #78362
@malfet malfet requested a review from jeffdaily as a code owner May 26, 2022 16:44
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 26, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures, 5 Pending

As of commit dae2599 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7 / test (default, 4, 4, linux.4xlarge.nvidia.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-26T19:06:55.4686182Z FAIL [3.439s]: test_mem_leak (__main__.TestProfilerCUDA) 
2022-05-26T19:06:55.3795532Z STAGE:2022-05-26 19:06:55 17785:17785 ActivityProfilerController.cpp:300] Completed Stage: Collection
2022-05-26T19:06:55.3977400Z ok (0.070s)
2022-05-26T19:06:55.4005782Z   test_datapipe_with_record_function_fork (__main__.TestRecordFunction) ... STAGE:2022-05-26 19:06:55 17785:17785 ActivityProfilerController.cpp:294] Completed Stage: Warm Up
2022-05-26T19:06:55.4453021Z STAGE:2022-05-26 19:06:55 17785:17785 ActivityProfilerController.cpp:300] Completed Stage: Collection
2022-05-26T19:06:55.4622534Z ok (0.064s)
2022-05-26T19:06:55.4655901Z   test_record_function (__main__.TestRecordFunction) ... STAGE:2022-05-26 19:06:55 17785:17785 ActivityProfilerController.cpp:294] Completed Stage: Warm Up
2022-05-26T19:06:55.4672025Z STAGE:2022-05-26 19:06:55 17785:17785 ActivityProfilerController.cpp:300] Completed Stage: Collection
2022-05-26T19:06:55.4684198Z ok (0.006s)
2022-05-26T19:06:55.4685143Z 
2022-05-26T19:06:55.4685538Z ======================================================================
2022-05-26T19:06:55.4686182Z FAIL [3.439s]: test_mem_leak (__main__.TestProfilerCUDA)
2022-05-26T19:06:55.4686745Z Checks that there's no memory leak when using profiler with CUDA
2022-05-26T19:06:55.4687232Z ----------------------------------------------------------------------
2022-05-26T19:06:55.4687564Z Traceback (most recent call last):
2022-05-26T19:06:55.4688260Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 1287, in wrap_fn
2022-05-26T19:06:55.4688989Z     return fn(self, *args, **kwargs)
2022-05-26T19:06:55.4689527Z   File "test_profiler.py", line 69, in test_mem_leak
2022-05-26T19:06:55.4690461Z     msg='memory usage is increasing, {}'.format(str(last_rss)))
2022-05-26T19:06:55.4691368Z AssertionError: False is not true : memory usage is increasing, deque([2063204352, 2063208448, 2063355904, 2064142336, 2065195008], maxlen=5)
2022-05-26T19:06:55.4691911Z 
2022-05-26T19:06:55.4692436Z ----------------------------------------------------------------------
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet requested a review from a team May 26, 2022 16:44
@malfet
Copy link
Contributor Author

malfet commented May 26, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request May 31, 2022
@malfet @pruthvistony
[Docker] Pin protobuf to 3.20.1 (pytorch#78369)
e00eac7 
To protect CI from sudden version updates, that are not compatible with other packages

Fixes pytorch#78362

Pull Request resolved: pytorch#78369
Approved by: https://github.com/suo, https://github.com/atalman
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request May 31, 2022
@malfet @pruthvistony
[Docker] Pin protobuf to 3.20.1 (pytorch#78369)
f01e610 
To protect CI from sudden version updates, that are not compatible with other packages

Fixes pytorch#78362

Pull Request resolved: pytorch#78369
Approved by: https://github.com/suo, https://github.com/atalman
facebook-github-bot pushed a commit that referenced this pull request May 31, 2022
@malfet @facebook-github-bot
[Docker] Pin protobuf to 3.20.1 (#78369) (#78369)
d157f6a 
Summary:
To protect CI from sudden version updates, that are not compatible with other packages

Fixes #78362

Pull Request resolved: #78369
Approved by: https://github.com/suo, https://github.com/atalman

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6b4ffa14df70e3bd93e3e77ed2690443c0da660d

Reviewed By: seemethere

Differential Revision: D36783214

Pulled By: malfet

fbshipit-source-id: c28e3d4ce77adf8113618de367df508466daf906
@malfet malfet deleted the malfet-patch-14 branch June 1, 2022 19:31
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suo suo suo approved these changes

@atalman atalman atalman approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Numerous builds/tests are broken by protobuf update

6 participants

@malfet @facebook-github-bot @suo @atalman @pytorchmergebot