Skip to content

move Subset, random_split to data, use sequence at some places. #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
apaszke merged 1 commit into from
May 25, 2018
Merged

move Subset, random_split to data, use sequence at some places. #7816

apaszke merged 1 commit into from
May 25, 2018

Conversation

@zasdfgbnm
Copy link
Collaborator

@zasdfgbnm zasdfgbnm commented May 24, 2018

This PR propose the following changes:

  1. Move torch.utils.data.dataset.random_split to torch.utils.data.random_split.
  2. Move torch.utils.data.dataset.Subset to torch.utils.data.Subset.
  3. Add docstring for Subset and expose it.
  4. Change some wording from 'iterable' and 'list' to 'sequence'.

Note:
The relationship between iterable and sequence is stated at python#term-sequence:

(A sequence is) an iterable which supports efficient element access using integer indices via the __getitem__() special method and defines a __len__() method that returns the length of the sequence.

@zasdfgbnm
Copy link
Collaborator Author

zasdfgbnm commented May 24, 2018

Some quick experiments:

import collections
f = open('examples.desktop')
print(isinstance(f, collections.Iterable))
print(isinstance(f, collections.Sequence))
f[0]

gives

True
False
Traceback (most recent call last):
  File "iterable-vs-sequence.py", line 5, in <module>
    f[0]
TypeError: '_io.TextIOWrapper' object is not subscriptable

And

import torch
class A:
	def __getitem__(self,idx):
		if idx == 0:
			return 0
		elif idx == 1:
			return 1
		else:
			raise IndexError('index out of range')
	def __len__(self):
		return 2

print(torch.tensor(A()))

gives

tensor([ 0,  1])

@apaszke
Copy link
Contributor

apaszke commented May 25, 2018

@pytorchbot retest this please

@apaszke apaszke merged commit d7c32df into pytorch:master May 25, 2018
@apaszke
Copy link
Contributor

apaszke commented May 25, 2018

Thanks @zasdfgbnm!

@zou3519 zou3519 mentioned this pull request May 25, 2018
Closed
@zasdfgbnm zasdfgbnm deleted the misc_docs branch May 25, 2018 14:39
weiyangfb pushed a commit to weiyangfb/pytorch that referenced this pull request Jun 11, 2018
@zasdfgbnm @weiyangfb
move Subset, random_split to data, use sequence at some places. (pyto…
19ec465 
…rch#7816)
@taketwo taketwo mentioned this pull request Jul 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

1 more reviewer

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zasdfgbnm @apaszke @ezyang