Skip to content

Conversation

@pietern
Copy link
Contributor

@pietern pietern commented May 23, 2018

Let's try to run this manually to keep style consistent.

Copy link
Contributor

@apaszke apaszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to start enforcing a strict style policy for c10d?

@pietern
Copy link
Contributor Author

pietern commented May 23, 2018

@apaszke Having a predictable/consistent style removes unnecessary cognitive overhead (at least for me it does), regardless of the style that is used. I would like to stick to it for c10d, yes. We can formalize this later though, right now only @teng-li and myself are checking in code.

@pietern pietern merged commit 7d0de4f into pytorch:master May 23, 2018
@pietern pietern deleted the c10d-clang-format branch May 23, 2018 18:26
petrex pushed a commit to petrex/pytorch that referenced this pull request May 31, 2018
* origin:
  [Caffe2] Enabling AMD GPU Backend for Caffe2 (pytorch#7566)
  Call grad_mode.py context managers as decorators (pytorch#7737)
  catch CPU tensors in checkSameGPU (fixes pytorch#7689) (pytorch#7767)
  Mark stack as non-executable in NNPACK (pytorch#7752)
  small fixes in fusion_compiler (pytorch#7776)
  Run clang-format on c10d (pytorch#7791)
weiyangfb pushed a commit to weiyangfb/pytorch that referenced this pull request Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants