Skip to content

Conversation

@pearu
Copy link
Collaborator

@pearu pearu commented May 15, 2022

Also fixes #59285

Stack from ghstack (oldest at bottom):

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 15, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit fd67d0c (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pearu pearu self-assigned this May 15, 2022
@pearu pearu added module: sparse Related to torch.sparse open source release notes: sparse release notes category topic: new features topic category labels May 15, 2022
pearu added a commit that referenced this pull request May 16, 2022
ghstack-source-id: 3eaafbf
Pull Request resolved: #77512
pearu added a commit that referenced this pull request May 16, 2022
ghstack-source-id: c2ea000
Pull Request resolved: #77512
@pearu pearu requested a review from cpuhrsch May 16, 2022 15:55
@pearu
Copy link
Collaborator Author

pearu commented May 16, 2022

@pytorchbot merge this on green

@malfet
Copy link
Contributor

malfet commented May 17, 2022

@pytorchbot revert this, as it broke OSS CI with "'function' object has no attribute 'split'", see https://hud.pytorch.org/pytorch/pytorch/commit/20ba6e693563c5a0cf67b0fb9413f68a8d91fd25

pytorchmergebot added a commit that referenced this pull request May 17, 2022
@pearu pearu reopened this May 17, 2022
pearu added a commit that referenced this pull request May 17, 2022
ghstack-source-id: 4f44f16
Pull Request resolved: #77512
@pearu pearu linked an issue May 17, 2022 that may be closed by this pull request
@pearu
Copy link
Collaborator Author

pearu commented May 17, 2022

@pytorchbot merge this on green

@atalman
Copy link
Contributor

atalman commented May 17, 2022

@pytorchmergebot revert this Dear @pearu sorry for trouble our GH1 tooling is having trouble to deal with use case like this when PR is opened reverted and opened and submitted again. Please open another PR and reland. We will import it and merge.

pytorchmergebot added a commit that referenced this pull request May 17, 2022
@malfet malfet reopened this May 17, 2022
@malfet
Copy link
Contributor

malfet commented May 17, 2022

@atalman this does not sound like a valid reason for revert (we should fix tooling if this is the case, but a lot of relands with the same PR number is allowed)
@pearu I will take care of re-landing and merging it on priority

@malfet
Copy link
Contributor

malfet commented May 17, 2022

@pytorchbot merge this

facebook-github-bot pushed a commit that referenced this pull request May 18, 2022
Summary:
Pull Request resolved: #77512

Approved by: https://github.com/cpuhrsch

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/dc882ed33d571f3b03d9954b64f69c4f56b74314

Reviewed By: b0noI

Differential Revision: D36451871

Pulled By: b0noI

fbshipit-source-id: a830f85ef8b7c41b1df8a57b19fcb82812a2d746
@facebook-github-bot facebook-github-bot deleted the gh/pearu/67/head branch May 21, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sparse CSR tensors do not support .clone()

7 participants