Skip to content

Replace SparseCsrTensorImpl crow/col_indices with compressed/plain_indices #77504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pearu wants to merge 5 commits into from
Closed

Replace SparseCsrTensorImpl crow/col_indices with compressed/plain_indices #77504

pearu wants to merge 5 commits into from

Conversation

@pearu
Copy link
Collaborator

@pearu pearu commented May 15, 2022 •
edited
Loading

@pearu pearu requested review from albanD and soulitzer as code owners May 15, 2022 10:15
@pearu pearu mentioned this pull request May 15, 2022
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 15, 2022 •
edited
Loading

🔗 Helpful links

❌ 1 New Failures

As of commit d44b9c4 (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-py3.7-clang9 / build (1/1)

Step: "Setup Linux" (full log | diagnosis details | 🔁 rerun)

2022-05-16T15:49:31.0412232Z ##[error]Process completed with exit code 1. 
2022-05-16T15:49:14.3147777Z �[36;1m    --password-stdin "$AWS_ACCOUNT_ID.dkr.ecr.$AWS_DEFAULT_REGION.amazonaws.com"�[0m
2022-05-16T15:49:14.3159208Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-05-16T15:49:14.3159437Z env:
2022-05-16T15:49:14.3159581Z   IN_CI: 1
2022-05-16T15:49:14.3159740Z   IS_GHA: 1
2022-05-16T15:49:14.3159916Z   AWS_RETRY_MODE: standard
2022-05-16T15:49:14.3160104Z   AWS_MAX_ATTEMPTS: 5
2022-05-16T15:49:14.3160307Z   AWS_DEFAULT_REGION: us-east-1
2022-05-16T15:49:14.3160496Z ##[endgroup]
2022-05-16T15:49:31.0384978Z Error response from daemon: Get "https://308535385114.dkr.ecr.us-east-1.amazonaws.com/v2/": dial tcp 52.207.187.83:443: i/o timeout
2022-05-16T15:49:31.0412232Z ##[error]Process completed with exit code 1.
2022-05-16T15:49:31.0600126Z Prepare all required actions
2022-05-16T15:49:31.0619991Z ##[group]Run ./.github/actions/teardown-linux
2022-05-16T15:49:31.0620185Z with:
2022-05-16T15:49:31.0620340Z env:
2022-05-16T15:49:31.0620493Z   IN_CI: 1
2022-05-16T15:49:31.0620639Z   IS_GHA: 1
2022-05-16T15:49:31.0620805Z ##[endgroup]
2022-05-16T15:49:31.0635283Z ##[group]Run .github/scripts/wait_for_ssh_to_drain.sh
2022-05-16T15:49:31.0635547Z �[36;1m.github/scripts/wait_for_ssh_to_drain.sh�[0m
2022-05-16T15:49:31.0646602Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@pearu pearu self-assigned this May 15, 2022
@pearu pearu added module: sparse Related to torch.sparse release notes: sparse release notes category topic: not user facing topic category labels May 15, 2022
This was referenced May 15, 2022
Closed
Closed
@pearu pearu requested a review from cpuhrsch May 16, 2022 04:42
This was referenced May 16, 2022
Closed
Closed
@albanD albanD removed their request for review May 16, 2022 14:39
@cpuhrsch
Copy link
Contributor

cpuhrsch commented May 16, 2022

@pytorchbot merge this

facebook-github-bot pushed a commit that referenced this pull request May 17, 2022
@pearu @facebook-github-bot
Replace SparseCsrTensorImpl crow/col_indices with compressed/plain_in…
4e1cbd0 
…dices (#77504)

Summary:
Pull Request resolved: #77504

Approved by: https://github.com/cpuhrsch

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/77f1ca00656e0279bd16c99500f67d4b9c397f30

Reviewed By: atalman

Differential Revision: D36421646

fbshipit-source-id: 16fe8dcaa889464bba3cf269799772a1ad2f2040
@facebook-github-bot facebook-github-bot deleted the gh/pearu/65/head branch May 20, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

@pearu pearu

Labels

cla signed Merged module: sparse Related to torch.sparse open source release notes: sparse release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pearu @facebook-github-bot @cpuhrsch @pytorchbot @pytorchmergebot