Skip to content

[distributions] Always enable grad when calculating lazy_property #7708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssnl merged 2 commits into from
May 24, 2018
Merged

[distributions] Always enable grad when calculating lazy_property #7708

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db3aab1
Always enable grad when calculating lazy_property
ssnl May 19, 2018
e860e39
Add test with MultiVariableNormal
ssnl May 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test with MultiVariableNormal
  • Loading branch information
@ssnl
ssnl committed May 19, 2018
commit e860e39f173f673536341d5ce8ce11dd4fe254ff
8 changes: 8 additions & 0 deletions test/test_distributions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,6 +707,14 @@ def test():
with torch.no_grad():
test()

This comment was marked as off-topic.

Sign in to view


mean = torch.randn(2)
cov = torch.eye(2, requires_grad=True)
distn = MultivariateNormal(mean, cov)
with torch.no_grad():
distn.scale_tril
distn.scale_tril.sum().backward()
self.assertIsNotNone(cov.grad)

def test_has_examples(self):
distributions_with_examples = set(e.Dist for e in EXAMPLES)
for Dist in globals().values():
Expand Down