Skip to content

switch Bazel to the shared generate-code genrule #75790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dagitses wants to merge 52 commits into from
Closed

switch Bazel to the shared generate-code genrule #75790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
1f2b63c
switch Bazel to the shared generate-code genrule
Apr 14, 2022
d0077cc
Update on "switch Bazel to the shared generate-code genrule"
Apr 14, 2022
21a9671
Update on "switch Bazel to the shared generate-code genrule"
Apr 15, 2022
bfa8049
Update on "switch Bazel to the shared generate-code genrule"
Apr 15, 2022
ad6ee25
Update on "switch Bazel to the shared generate-code genrule"
Apr 15, 2022
d0a4831
Update on "switch Bazel to the shared generate-code genrule"
Apr 15, 2022
c24117f
Update on "switch Bazel to the shared generate-code genrule"
Apr 15, 2022
96d6eef
Update on "switch Bazel to the shared generate-code genrule"
Apr 15, 2022
226e2e1
Update on "switch Bazel to the shared generate-code genrule"
Apr 16, 2022
5851159
Update on "switch Bazel to the shared generate-code genrule"
Apr 16, 2022
d63d115
Update on "switch Bazel to the shared generate-code genrule"
Apr 16, 2022
2c329ab
Update on "switch Bazel to the shared generate-code genrule"
Apr 16, 2022
ebe3ad5
Update on "switch Bazel to the shared generate-code genrule"
Apr 16, 2022
4268c93
Update on "switch Bazel to the shared generate-code genrule"
Apr 16, 2022
bc4e5e3
Update on "switch Bazel to the shared generate-code genrule"
Apr 16, 2022
3fcb479
Update on "switch Bazel to the shared generate-code genrule"
Apr 16, 2022
a157213
Update on "switch Bazel to the shared generate-code genrule"
Apr 17, 2022
38995c7
Update on "switch Bazel to the shared generate-code genrule"
Apr 18, 2022
4f1a0e2
Update on "switch Bazel to the shared generate-code genrule"
Apr 18, 2022
62925f8
Update on "switch Bazel to the shared generate-code genrule"
Apr 18, 2022
3c9d1e0
Update on "switch Bazel to the shared generate-code genrule"
Apr 18, 2022
9686bed
Update on "switch Bazel to the shared generate-code genrule"
Apr 19, 2022
3e70210
Update on "switch Bazel to the shared generate-code genrule"
Apr 19, 2022
7c2ab58
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
9356eeb
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
d63fc85
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
941b6b9
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
55da808
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
ed92105
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
1c06023
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
3b02d64
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
4ad608b
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
d30abac
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
ef548e5
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
07af0e6
Update on "switch Bazel to the shared generate-code genrule"
Apr 21, 2022
da0d6f8
Update on "switch Bazel to the shared generate-code genrule"
Apr 22, 2022
802867f
Update on "switch Bazel to the shared generate-code genrule"
Apr 22, 2022
f27db80
Update on "switch Bazel to the shared generate-code genrule"
Apr 25, 2022
78f073f
Update on "switch Bazel to the shared generate-code genrule"
Apr 25, 2022
827f11f
Update on "switch Bazel to the shared generate-code genrule"
Apr 25, 2022
4d641cd
Update on "switch Bazel to the shared generate-code genrule"
Apr 26, 2022
6f12ba1
Update on "switch Bazel to the shared generate-code genrule"
Apr 27, 2022
b5e1c4b
Update on "switch Bazel to the shared generate-code genrule"
Apr 30, 2022
618a706
Update on "switch Bazel to the shared generate-code genrule"
May 2, 2022
9018df9
Update on "switch Bazel to the shared generate-code genrule"
May 2, 2022
ebd5e31
Update on "switch Bazel to the shared generate-code genrule"
May 2, 2022
6e24065
Update on "switch Bazel to the shared generate-code genrule"
May 2, 2022
80d64b4
Update on "switch Bazel to the shared generate-code genrule"
May 2, 2022
dbec737
Update on "switch Bazel to the shared generate-code genrule"
May 2, 2022
b05d129
Update on "switch Bazel to the shared generate-code genrule"
May 3, 2022
ae27cd6
Update on "switch Bazel to the shared generate-code genrule"
May 3, 2022
08b98ca
Update on "switch Bazel to the shared generate-code genrule"
May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,33 +148,15 @@ libtorch_python_generated_sources = [
"torch/csrc/autograd/generated/python_return_types.cpp",
]

genrule(
name = "all_generated_code",
srcs = [
"aten/src/ATen/native/native_functions.yaml",
"aten/src/ATen/native/tags.yaml",
"aten/src/ATen/native/ts_native_functions.yaml",
"torch/csrc/lazy/core/shape_inference.h",
"torch/csrc/lazy/ts_backend/ts_native_functions.cpp",
"aten/src/ATen/templates/DispatchKeyNativeFunctions.cpp",
"aten/src/ATen/templates/DispatchKeyNativeFunctions.h",
"aten/src/ATen/templates/RegisterDispatchKey.cpp",
"aten/src/ATen/templates/LazyIr.h",
],
outs = libtorch_cpp_generated_sources + libtorch_python_generated_sources,
cmd = "$(location //tools/setup_helpers:generate_code) --install_dir `dirname $(location torch/csrc/autograd/generated/variable_factories.h)`/../.. --native-functions-path $(location aten/src/ATen/native/native_functions.yaml) --tags-path $(location aten/src/ATen/native/tags.yaml) --gen_lazy_ts_backend",
tools = ["//tools/setup_helpers:generate_code"],
)

filegroup(
name = "cpp_generated_code",
data = [":all_generated_code"],
data = [":generate-code"],
srcs = libtorch_cpp_generated_sources,
)

filegroup(
name = "python_generated_code",
data = [":all_generated_code"],
data = [":generate-code"],
srcs = libtorch_python_generated_sources,
)

Expand Down
9 changes: 3 additions & 6 deletions build.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,6 @@ def define_targets(rules):
"--native-functions-path $(location :native_functions.yaml) " +
"--tags-path=$(location :tags.yaml) " +
"--gen_lazy_ts_backend",
tags = [
# Filter this target out for Bazel until we are ready to
# use it. When we refactor this for fbcode it will start
# to conflict with the Bazel code generator.
"-bazel",
],
)

rules.genrule(
Expand Down Expand Up @@ -117,4 +111,7 @@ _GENERATED_CPP = [
"torch/csrc/autograd/generated/python_torch_functions_1.cpp",
"torch/csrc/autograd/generated/python_torch_functions_2.cpp",
"torch/csrc/autograd/generated/python_variable_methods.cpp",
"torch/csrc/lazy/generated/LazyNativeFunctions.cpp",
"torch/csrc/lazy/generated/RegisterAutogradLazy.cpp",
"torch/csrc/lazy/generated/RegisterLazy.cpp",
]