Skip to content

Move bernoulli further into ATen #7578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpuhrsch merged 1 commit into from
May 16, 2018
Merged

Move bernoulli further into ATen #7578

cpuhrsch merged 1 commit into from
May 16, 2018

Conversation

@cpuhrsch
Copy link
Contributor

@cpuhrsch cpuhrsch commented May 15, 2018

This addresses some of the points mentioned in this issue and should generally improve perf of some of those operations (it avoids a few unnecessary expands).

@onnxbot-worker-1 onnxbot-worker-1 mentioned this pull request May 15, 2018
Closed
@cpuhrsch cpuhrsch force-pushed the mba branch 3 times, most recently from e12fea9 to af32f96 Compare May 15, 2018 18:50
apaszke
apaszke approved these changes May 15, 2018
View reviewed changes
Copy link
Contributor

@apaszke apaszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will conflict with #7171 😕

aten/src/ATen/native/Distributions.cpp Outdated

This comment was marked as off-topic.

Sign in to view

aten/src/ATen/native/Distributions.cpp Outdated

This comment was marked as off-topic.

Sign in to view

@MlWoo MlWoo mentioned this pull request May 16, 2018
Merged
@MlWoo
Copy link
Contributor

MlWoo commented May 16, 2018 •
edited
Loading

@apaszke It will be OK to resolve the confiict for me.

@ezyang
Copy link
Contributor

ezyang commented May 16, 2018 

19:26:38 ======================================================================
19:26:38 ERROR: test_bernoulli (test_torch.TestTorch)
19:26:38 ----------------------------------------------------------------------
19:26:38 Traceback (most recent call last):
19:26:38   File "test_torch.py", line 6062, in test_bernoulli
19:26:38     t.bernoulli_(p)
19:26:38 RuntimeError: expected scalar type % s but found %sByteDouble
19:26:38 
19:26:38 ----------------------------------------------------------------------

NB: the error reporting format for AT_ERROR and co has changed, don't use printf strings.

@cpuhrsch cpuhrsch force-pushed the mba branch 2 times, most recently from d72e7fa to f32298f Compare May 16, 2018 21:23
@cpuhrsch
Copy link
Contributor Author

cpuhrsch commented May 16, 2018

I restarted the failed build which is now running here: https://ci.pytorch.org/jenkins/job/pytorch-builds/job/pytorch-linux-trusty-py3.6-gcc7.2-trigger/7061/

It's a known issue that the github web ui doesn't pick up on it.

@cpuhrsch cpuhrsch merged commit 221e615 into pytorch:master May 16, 2018
onnxbot added a commit to onnxbot/onnx-fb-universe that referenced this pull request May 16, 2018
@onnxbot
[auto] Update pytorch to 221e615 - Move bernoulli further into ATen (p…
5b95cfc 
…ytorch/pytorch#7578)

pytorch/pytorch@221e615
weiyangfb pushed a commit to weiyangfb/pytorch that referenced this pull request Jun 11, 2018
@cpuhrsch @weiyangfb
Move bernoulli further into ATen (pytorch#7578)
0c50f22
@ngimel ngimel mentioned this pull request Jun 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

1 more reviewer

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpuhrsch @MlWoo @ezyang @apaszke