Skip to content

Add complex32 support to torch.lerp #75584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
khushi-411 wants to merge 27 commits into from
Closed

Add complex32 support to torch.lerp #75584

khushi-411 wants to merge 27 commits into from

Conversation

@khushi-411
Copy link
Contributor

@khushi-411 khushi-411 commented Apr 10, 2022 •
edited by pytorch-bot bot
Loading

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 10, 2022 •
edited
Loading

🔗 Helpful links

❌ 4 New Failures

As of commit 38bf73c (more details on the Dr. CI page):

Expand to see more
  • 4/4 failures introduced in this PR

🕵️ 4 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 2, 4, linux.4xlarge.nvidia.gpu) (1/4)

Step: "Test" (full log | diagnosis details)

2022-09-06T05:09:54.7957201Z RuntimeError: test_decomp failed! 
2022-09-06T05:09:53.0902929Z 
2022-09-06T05:09:53.0903101Z FAILED (errors=3, skipped=384, expected failures=25)
2022-09-06T05:09:53.0903120Z 
2022-09-06T05:09:53.0903246Z Generating XML reports...
2022-09-06T05:09:53.8035006Z Generated XML report: test-reports/python-unittest/test_decomp/TEST-TestDecompCUDA-20220906043431.xml
2022-09-06T05:09:54.7951039Z Traceback (most recent call last):
2022-09-06T05:09:54.7951802Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1104, in <module>
2022-09-06T05:09:54.7952960Z     main()
2022-09-06T05:09:54.7954013Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1082, in main
2022-09-06T05:09:54.7956564Z     raise RuntimeError(err_message)
2022-09-06T05:09:54.7957201Z RuntimeError: test_decomp failed!
2022-09-06T05:09:55.0915130Z 
2022-09-06T05:09:55.0915747Z real	35m30.134s
2022-09-06T05:09:55.0916117Z user	34m21.759s
2022-09-06T05:09:55.0916351Z sys	1m13.719s
2022-09-06T05:09:55.0974141Z ##[error]Process completed with exit code 1.
2022-09-06T05:09:55.1022826Z Prepare all required actions
2022-09-06T05:09:55.1023204Z Getting action download info
2022-09-06T05:09:55.2595323Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-09-06T05:09:55.2596053Z with:
2022-09-06T05:09:55.2596613Z   github-token: ***

See GitHub Actions build pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 4, 4, linux.4xlarge.nvidia.gpu) (2/4)

Step: "Test" (full log | diagnosis details)

2022-09-06T04:55:53.4081579Z RuntimeError: test_ops_jit failed! 
2022-09-06T04:55:47.6301426Z 
2022-09-06T04:55:47.6301599Z FAILED (errors=1, skipped=105, expected failures=164)
2022-09-06T04:55:47.6301619Z 
2022-09-06T04:55:47.6301749Z Generating XML reports...
2022-09-06T04:55:47.7061715Z Generated XML report: test-reports/python-unittest/test_ops_jit/TEST-TestJitCUDA-20220906043612.xml
2022-09-06T04:55:53.4076275Z Traceback (most recent call last):
2022-09-06T04:55:53.4076761Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1104, in <module>
2022-09-06T04:55:53.4078379Z     main()
2022-09-06T04:55:53.4078731Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1082, in main
2022-09-06T04:55:53.4081274Z     raise RuntimeError(err_message)
2022-09-06T04:55:53.4081579Z RuntimeError: test_ops_jit failed!
2022-09-06T04:55:53.7368190Z 
2022-09-06T04:55:53.7368773Z real	19m47.972s
2022-09-06T04:55:53.7369590Z user	19m15.150s
2022-09-06T04:55:53.7369859Z sys	0m31.577s
2022-09-06T04:55:53.7429549Z ##[error]Process completed with exit code 1.
2022-09-06T04:55:53.7477697Z Prepare all required actions
2022-09-06T04:55:53.7478168Z Getting action download info
2022-09-06T04:55:53.9370854Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-09-06T04:55:53.9371172Z with:
2022-09-06T04:55:53.9371636Z   github-token: ***

See GitHub Actions build pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 3, 4, linux.4xlarge.nvidia.gpu) (3/4)

Step: "Test" (full log | diagnosis details)

2022-09-06T05:04:16.0089340Z RuntimeError: test_ops_gradients failed! 
2022-09-06T05:04:14.2777886Z 
2022-09-06T05:04:14.2778040Z FAILED (errors=7, skipped=3951, expected failures=83)
2022-09-06T05:04:14.2778060Z 
2022-09-06T05:04:14.2778166Z Generating XML reports...
2022-09-06T05:04:15.1053287Z Generated XML report: test-reports/python-unittest/test_ops_gradients/TEST-TestGradientsCUDA-20220906043303.xml
2022-09-06T05:04:16.0084722Z Traceback (most recent call last):
2022-09-06T05:04:16.0085814Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1104, in <module>
2022-09-06T05:04:16.0086622Z     main()
2022-09-06T05:04:16.0086959Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1082, in main
2022-09-06T05:04:16.0088981Z     raise RuntimeError(err_message)
2022-09-06T05:04:16.0089340Z RuntimeError: test_ops_gradients failed!
2022-09-06T05:04:16.2796573Z 
2022-09-06T05:04:16.2797288Z real	31m19.273s
2022-09-06T05:04:16.2797579Z user	30m14.310s
2022-09-06T05:04:16.2797812Z sys	1m38.538s
2022-09-06T05:04:16.2847065Z ##[error]Process completed with exit code 1.
2022-09-06T05:04:16.2891285Z Prepare all required actions
2022-09-06T05:04:16.2891625Z Getting action download info
2022-09-06T05:04:16.5824085Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-09-06T05:04:16.5824381Z with:
2022-09-06T05:04:16.5824837Z   github-token: ***

See GitHub Actions build pull / linux-bionic-cuda11.6-py3.10-gcc7 / test (default, 1, 4, linux.4xlarge.nvidia.gpu) (4/4)

Step: "Test" (full log | diagnosis details)

2022-09-06T06:10:59.6784258Z RuntimeError: test_ops failed! 
2022-09-06T06:10:54.9332125Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestCommonCUDA-20220906043805.xml
2022-09-06T06:10:55.1445306Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestCompositeComplianceCUDA-20220906043805.xml
2022-09-06T06:10:56.0554097Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestFakeTensorNonErroringCUDA-20220906043805.xml
2022-09-06T06:10:56.2383191Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestMathBitsCUDA-20220906043805.xml
2022-09-06T06:10:56.3397218Z Generated XML report: test-reports/python-unittest/test_ops/TEST-TestTagsCUDA-20220906043805.xml
2022-09-06T06:10:59.6779320Z Traceback (most recent call last):
2022-09-06T06:10:59.6779827Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1104, in <module>
2022-09-06T06:10:59.6780700Z     main()
2022-09-06T06:10:59.6781113Z   File "/var/lib/jenkins/workspace/test/run_test.py", line 1082, in main
2022-09-06T06:10:59.6783783Z     raise RuntimeError(err_message)
2022-09-06T06:10:59.6784258Z RuntimeError: test_ops failed!
2022-09-06T06:10:59.9866898Z 
2022-09-06T06:10:59.9867149Z real	93m1.745s
2022-09-06T06:10:59.9867469Z user	91m42.376s
2022-09-06T06:10:59.9867899Z sys	1m27.529s
2022-09-06T06:10:59.9932773Z ##[error]Process completed with exit code 1.
2022-09-06T06:10:59.9981184Z Prepare all required actions
2022-09-06T06:10:59.9981561Z Getting action download info
2022-09-06T06:11:00.2369884Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-09-06T06:11:00.2370201Z with:
2022-09-06T06:11:00.2370729Z   github-token: ***
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@khushi-411 khushi-411 marked this pull request as draft April 10, 2022 16:43
@khushi-411 khushi-411 changed the title [jiterator] lerp [jiterator, complex32] lerp : cuda May 22, 2022
@khushi-411 khushi-411 marked this pull request as ready for review May 22, 2022 20:09
khushi-411
khushi-411 commented May 22, 2022
View reviewed changes
kshitij12345
kshitij12345 reviewed May 22, 2022
View reviewed changes
kshitij12345
kshitij12345 reviewed May 23, 2022
View reviewed changes
kshitij12345
kshitij12345 reviewed May 30, 2022
View reviewed changes
@ejguan ejguan added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module module: jiterator labels May 31, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 4, 2022

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 4, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/75584

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4672e37:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@khushi-411
Copy link
Contributor Author

khushi-411 commented Oct 4, 2022

/easycla

@mruberry mruberry requested a review from anjali411 October 4, 2022 15:55
anjali411
anjali411 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@anjali411 anjali411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @khushi-411 is there anything blocking this PR?

@khushi-411
Copy link
Contributor Author

khushi-411 commented Nov 28, 2022 •
edited
Loading

Hi, @anjali411! Thanks for reviewing.

@khushi-411 is there anything blocking this PR?

Yes, the CI failures are relevant. I'll resolve this by today. Thanks!

@khushi-411
Copy link
Contributor Author

khushi-411 commented Nov 30, 2022

@pytorchmergebot merge

The CI goes green, Merging this PR. Yay! Thanks for reviewing @anjali411 and @kshitij12345! :)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 30, 2022
@khushi-411
Copy link
Contributor Author

khushi-411 commented Nov 30, 2022

I think approval is needed for one workflow. Gentle ping, @anjali411.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 30, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@khushi-411 khushi-411 deleted the jiterator/lerp branch December 1, 2022 05:13
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@khushi-411 @kulinseth
[jiterator, complex32] lerp : cuda (pytorch#75584)
c86be2d 
Follows pytorch#74748 and pytorch#74537

Pull Request resolved: pytorch#75584
Approved by: https://github.com/anjali411
@lezcano lezcano changed the title [jiterator, complex32] lerp : cuda Add complex32 support to torch.lerp Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kshitij12345 kshitij12345 kshitij12345 left review comments

@anjali411 anjali411 anjali411 approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged module: jiterator open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@khushi-411 @facebook-github-bot @pytorchmergebot @kshitij12345 @anjali411 @pytorchbot @ejguan