Skip to content

[quant] add checking number of args when checking observer in same graph #75460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
terrychenism wants to merge 1 commit into from
Closed

[quant] add checking number of args when checking observer in same graph #75460

terrychenism wants to merge 1 commit into from

Conversation

@terrychenism
Copy link
Contributor

@terrychenism terrychenism commented Apr 7, 2022 •
edited by jerryzh168
Loading

Stack from ghstack (oldest at bottom):

Summary:
add checking for number of args checking observer in same graph

Test Plan:
python3 test/test_quantization.py TestQuantizeFx
python3 test/test_quantization.py TestQuantizeFxOps

the error is hit by some internal use cases as well

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D35479504

@terrychenism
[quant] add checking number of args when checking observer in same graph
e2682c7 
Summary:
add checking for number of args checking observer in same graph

Test Plan:
python3 test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 7, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e2682c7 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

terrychenism added a commit that referenced this pull request Apr 7, 2022
@terrychenism
[quant] add checking number of args when checking observer in same graph
f0367bf 
Summary:
add checking for number of args checking observer in same graph

Test Plan:
python3 test/test_quantization.py TestQuantizeFxOps

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 1cf2c7a
Pull Request resolved: #75460
@terrychenism
Copy link
Contributor Author

terrychenism commented Apr 7, 2022

@terrychenism has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@terrychenism terrychenism requested a review from jerryzh168 April 7, 2022 21:11
facebook-github-bot pushed a commit that referenced this pull request Apr 8, 2022
@terrychenism @facebook-github-bot
[quant] add checking number of args when checking observer in same gr…
45542f7 
…aph (#75460)

Summary:
Pull Request resolved: #75460

add checking for number of args checking observer in same graph

Test Plan:
python3 test/test_quantization.py TestQuantizeFxOps

Imported from OSS

Reviewed By: malfet

Differential Revision: D35479504

fbshipit-source-id: d7dc38a27fdf8e0b236b6976d484b0701c61184c
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Hey @terrychenism.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/terrychenism/26/head branch April 11, 2022 14:17
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees

No one assigned

Labels

cla signed module: fx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@terrychenism @facebook-github-bot @jerryzh168