Skip to content

Fix duplicate commit logic in syncbranches #75384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

Fix duplicate commit logic in syncbranches #75384

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Apr 6, 2022

Regression introduced by caa4030

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 6, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 8f25e23 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 6, 2022

@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Apr 6, 2022
@malfet @facebook-github-bot
Fix duplicate commit logic in syncbranches (#75384)
7129435 
Summary:
Regression introduced by caa4030

Pull Request resolved: #75384

Reviewed By: osalpekar

Differential Revision: D35451233

Pulled By: malfet

fbshipit-source-id: bbe81d2138a14337e1702f53a609c03c1fef3e91
@bigfootjon bigfootjon deleted the malfet-patch-5 branch April 6, 2022 23:29
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bigfootjon bigfootjon bigfootjon approved these changes

@osalpekar osalpekar osalpekar approved these changes

@seemethere seemethere Awaiting requested review from seemethere

@janeyx99 janeyx99 Awaiting requested review from janeyx99

@atalman atalman Awaiting requested review from atalman

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @facebook-github-bot @bigfootjon @osalpekar