Skip to content

clamping the return value of uniform.cdf() to [0..1] #7538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ezyang merged 3 commits into from
May 14, 2018
Merged

clamping the return value of uniform.cdf() to [0..1] #7538

ezyang merged 3 commits into from
May 14, 2018

Conversation

@andreh7
Copy link
Contributor

@andreh7 andreh7 commented May 13, 2018

fixes #7532

@andreh7 andreh7 mentioned this pull request May 13, 2018
Closed
@ezyang
Copy link
Contributor

ezyang commented May 13, 2018

Can we get a test for this?

@andreh7
Copy link
Contributor Author

andreh7 commented May 13, 2018

@ezyang where would such a (unit) test have to go ?

@ezyang
Copy link
Contributor

ezyang commented May 13, 2018

test_distributions.py

@andreh7
Copy link
Contributor Author

andreh7 commented May 14, 2018

thanks, I have added a corresponding test for arguments outside the boundaries for uniform.cdf() , similar to the test for uniform.log_prob() in 5f1f34c

fritzo
fritzo approved these changes May 14, 2018
View reviewed changes
Copy link
Collaborator

@fritzo fritzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@ezyang ezyang merged commit 61afbbb into pytorch:master May 14, 2018
weiyangfb pushed a commit to weiyangfb/pytorch that referenced this pull request Jun 11, 2018
@andreh7 @weiyangfb
clamping the return value of uniform.cdf() to [0..1] (pytorch#7538)
1ba8d96 
* fix for pytorch#7532: clamping the return value of uniform.cdf() to the range [0,1]

* removed whitespace around equals to pass flake8 tests

* added a test for uniform.cdf() with arguments outside support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@fritzo fritzo fritzo approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.distributions.uniform.Uniform.cdf() can return negative values or values above one

3 participants

@andreh7 @ezyang @fritzo