[quant][fx] Using native backend_config_dict in fusion #75378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered, now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now. This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None, we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in quantization code base. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 6, 2022
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b59a15c (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 6, 2022
Summary: Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered, now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now. This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None, we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in quantization code base. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 6, 2022
Closed
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
vkuzo
approved these changes
Apr 7, 2022
Summary: Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered, now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now. This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None, we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in quantization code base. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35451962](https://our.internmc.facebook.com/intern/diff/D35451962) [ghstack-poisoned]
Summary: Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered, now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now. This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None, we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in quantization code base. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35451962](https://our.internmc.facebook.com/intern/diff/D35451962) [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered, now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now. This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None, we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in quantization code base. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35451962](https://our.internmc.facebook.com/intern/diff/D35451962) [ghstack-poisoned]
This was referenced Apr 8, 2022
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered, now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now. This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None, we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in quantization code base. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35451962](https://our.internmc.facebook.com/intern/diff/D35451962) [ghstack-poisoned]
Summary: Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered, now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now. This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None, we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in quantization code base. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35451962](https://our.internmc.facebook.com/intern/diff/D35451962) [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered, now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now. This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None, we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in quantization code base. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35451962](https://our.internmc.facebook.com/intern/diff/D35451962) [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 9, 2022
Summary: Pull Request resolved: #75378 Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered, now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now. This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None, we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in quantization code base. Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Imported from OSS Reviewed By: vkuzo Differential Revision: D35451962 fbshipit-source-id: 31d51850c669e061b67d6d9e0efec994f7ea79ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Previously we are still relying on the registration mechnism and get the default fusion patterns that are registered,
now we have moved all registration to backend_config_dict we can get all fusion patterns just from backend_config_dict now.
This PR enables using native backend_config_dict everywhere in fusion when the backend_config_dict is None,
we'll do similar changes for prepare and convert in the future, to fully enable backend_config_dict in
quantization code base.
Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D35451962