[quant] adding const qualifier to Quantizer::equalTo #75355
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: fix issue 74538 Quantizer::equalTo missing const qualifier Equality test should be const. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e0d6442 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Summary: fix issue 74538 Quantizer::equalTo missing const qualifier Equality test should be const. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@terrychenism has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
the code makes sense. Could you fill out the test plan? Also, looks like there are some CI errors. Thanks for working on this. |
Summary: fix issue #74538 Quantizer::equalTo missing const qualifier Equality test should be const. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35444203](https://our.internmc.facebook.com/intern/diff/D35444203) [ghstack-poisoned]
Contributor
Author
|
@terrychenism has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: fix issue #74538 Quantizer::equalTo missing const qualifier Equality test should be const. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35444203](https://our.internmc.facebook.com/intern/diff/D35444203) [ghstack-poisoned]
Summary: fix issue #74538 Quantizer::equalTo missing const qualifier Equality test should be const. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35444203](https://our.internmc.facebook.com/intern/diff/D35444203) [ghstack-poisoned]
Summary: fix issue #74538 Quantizer::equalTo missing const qualifier Equality test should be const. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35444203](https://our.internmc.facebook.com/intern/diff/D35444203) [ghstack-poisoned]
Summary: fix issue #74538 Quantizer::equalTo missing const qualifier Equality test should be const. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35444203](https://our.internmc.facebook.com/intern/diff/D35444203) [ghstack-poisoned]
Summary: fix issue #74538 Quantizer::equalTo missing const qualifier Equality test should be const. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35444203](https://our.internmc.facebook.com/intern/diff/D35444203) [ghstack-poisoned]
Summary: fix issue #74538 Quantizer::equalTo missing const qualifier Equality test should be const. Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35444203](https://our.internmc.facebook.com/intern/diff/D35444203) [ghstack-poisoned]
Contributor
Author
|
@terrychenism has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
|
the test plan is still blank, please fill it out so we can accept the PR |
Contributor
Author
just wait for the CI test finish, now it's filled. |
vkuzo
approved these changes
Apr 7, 2022
Contributor
vkuzo
left a comment
vkuzo
left a comment
There was a problem hiding this comment.
thanks for working on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
fix issue #74538 Quantizer::equalTo missing const qualifier
Equality test should be const.
Test Plan:
All CI tests passed
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D35444203