[quant][fx] Move embedding ops to backend_config_dict #75317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: att, similar to previous PRs, this one moves dynamically quantized rnn ops to backend_config_dict we have some temporary configs in backend_config_dict, but it will be removed soon, we want to migrate everything to backend_config_dict so that we can enable this path for all the code in the code base, starting from prepare, then to convert. We can start this process after this PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 6, 2022
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit e55de91 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
thanks for the context, could we document the code with what is temporary? |
vkuzo
approved these changes
Apr 6, 2022
Contributor
Author
yeah we have that in the code |
jerryzh168
commented
Apr 6, 2022
| return self.overwrite_output_observer | ||
| return qconfig.activation | ||
|
|
||
| # This is temporary, and will be removed soon |
Contributor
Author
There was a problem hiding this comment.
this function, and also a key in backend_config_dict
Summary: att, similar to previous PRs, this one moves dynamically quantized rnn ops to backend_config_dict we have some temporary configs in backend_config_dict, but it will be removed soon, we want to migrate everything to backend_config_dict so that we can enable this path for all the code in the code base, starting from prepare, then to convert. We can start this process after this PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35423789](https://our.internmc.facebook.com/intern/diff/D35423789) [ghstack-poisoned]
This was referenced Apr 6, 2022
Summary: att, similar to previous PRs, this one moves dynamically quantized rnn ops to backend_config_dict we have some temporary configs in backend_config_dict, but it will be removed soon, we want to migrate everything to backend_config_dict so that we can enable this path for all the code in the code base, starting from prepare, then to convert. We can start this process after this PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35423789](https://our.internmc.facebook.com/intern/diff/D35423789) [ghstack-poisoned]
This was referenced Apr 6, 2022
Closed
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: att, similar to previous PRs, this one moves dynamically quantized rnn ops to backend_config_dict we have some temporary configs in backend_config_dict, but it will be removed soon, we want to migrate everything to backend_config_dict so that we can enable this path for all the code in the code base, starting from prepare, then to convert. We can start this process after this PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35423789](https://our.internmc.facebook.com/intern/diff/D35423789) [ghstack-poisoned]
Summary: att, similar to previous PRs, this one moves dynamically quantized rnn ops to backend_config_dict we have some temporary configs in backend_config_dict, but it will be removed soon, we want to migrate everything to backend_config_dict so that we can enable this path for all the code in the code base, starting from prepare, then to convert. We can start this process after this PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35423789](https://our.internmc.facebook.com/intern/diff/D35423789) [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 8, 2022
Summary: Pull Request resolved: #75317 att, similar to previous PRs, this one moves dynamically quantized rnn ops to backend_config_dict we have some temporary configs in backend_config_dict, but it will be removed soon, we want to migrate everything to backend_config_dict so that we can enable this path for all the code in the code base, starting from prepare, then to convert. We can start this process after this PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Imported from OSS Reviewed By: vkuzo Differential Revision: D35423789 fbshipit-source-id: 9391bde6f4cbceb45de4ce9aaee136c9bfde8ab7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
att, similar to previous PRs, this one moves dynamically quantized rnn ops
to backend_config_dict
we have some temporary configs in backend_config_dict, but it will be removed soon, we want to migrate
everything to backend_config_dict so that we can enable this path for all the code in the code base, starting
from prepare, then to convert. We can start this process after this PR
Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D35423789