Skip to content

[quant][fx] Move rnn ops to backend_config_dict #75316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jerryzh168 wants to merge 5 commits into from
Closed

[quant][fx] Move rnn ops to backend_config_dict #75316

jerryzh168 wants to merge 5 commits into from

Conversation

@jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Apr 6, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary:
att, similar to previous PRs, this one moves dynamically quantized rnn ops
to backend_config_dict
Currently the dtype check is not yet enabled, so we provided the dtype_configs but it is not really used yet,
we will enable it a bit later after we moved everything to backend_config_dict

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D35423792

@jerryzh168
[quant][fx] Move rnn ops to backend_config_dict
534cbae 
Summary:
att, similar to previous PRs, this one moves dynamically quantized rnn ops
to backend_config_dict
Currently the dtype check is not yet enabled, so we provided the dtype_configs but it is not really used yet,
we will enable it a bit later after we moved everything to backend_config_dict

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced Apr 6, 2022
Closed
Closed
Closed
This was referenced Apr 6, 2022
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 6, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit a97dba0 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / win-vs2019-cuda11.3-py3 / test (default, 1, 2, windows.8xlarge.nvidia.gpu) (1/1)

Step: "Setup Windows" (full log | diagnosis details | 🔁 rerun)

2022-04-08T00:54:47.1268060Z C:\actions-runner\...554b8ba4304.sh: line 2: python3: command not found 
2022-04-08T00:54:47.0468972Z   JOB_BASE_NAME: win-vs2019-cuda11.3-py3-test
2022-04-08T00:54:47.0469276Z   BUILD_ENVIRONMENT: win-vs2019-cuda11.3-py3
2022-04-08T00:54:47.0469538Z   PR_NUMBER: 75316
2022-04-08T00:54:47.0469854Z   SHA1: a97dba0fef632af1601dce1ce6655f51cbf9c854
2022-04-08T00:54:47.0470092Z   TAG: 
2022-04-08T00:54:47.0470289Z   WORKFLOW_ID: 2112208371
2022-04-08T00:54:47.0470710Z   GITHUB_TOKEN: ***
2022-04-08T00:54:47.0470922Z   GHA_WORKFLOW_JOB_ID: 
2022-04-08T00:54:47.0471144Z ##[endgroup]
2022-04-08T00:54:47.1145211Z + python3 -m pip install -r requirements.txt
2022-04-08T00:54:47.1268060Z C:\actions-runner\_work\_temp\2aec34c9-ffa8-409e-b029-e554b8ba4304.sh: line 2: python3: command not found
2022-04-08T00:54:47.1296839Z ##[error]Process completed with exit code 127.
2022-04-08T00:54:47.1548814Z Prepare all required actions
2022-04-08T00:54:47.1675373Z ##[group]Run ./.github/actions/teardown-win
2022-04-08T00:54:47.1675636Z with:
2022-04-08T00:54:47.1675800Z env:
2022-04-08T00:54:47.1675984Z   IN_CI: 1
2022-04-08T00:54:47.1676173Z   IS_GHA: 1
2022-04-08T00:54:47.1676496Z   GIT_DEFAULT_BRANCH: master
2022-04-08T00:54:47.1676725Z ##[endgroup]
2022-04-08T00:54:47.1909617Z ##[group]Run .github\scripts\wait_for_ssh_to_drain.ps1
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Apr 6, 2022
Closed
Closed
Closed
Closed
@jerryzh168 jerryzh168 requested review from andrewor14 and vkuzo April 6, 2022 07:06
@jerryzh168
Copy link
Contributor Author

jerryzh168 commented Apr 6, 2022

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jerryzh168 jerryzh168 added the topic: not user facing topic category label Apr 6, 2022
@vkuzo
Copy link
Contributor

vkuzo commented Apr 6, 2022

Currently the dtype check is not yet enabled, so we provided the dtype_configs but it is not really used yet,
we will enable it a bit later after we moved everything to backend_config_dict

can we document this in the code?

@jerryzh168
Update on "[quant][fx] Move rnn ops to backend_config_dict"
4507398 
Summary:
att, similar to previous PRs, this one moves dynamically quantized rnn ops
to backend_config_dict
Currently the dtype check is not yet enabled, so we provided the dtype_configs but it is not really used yet,
we will enable it a bit later after we moved everything to backend_config_dict

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35423792](https://our.internmc.facebook.com/intern/diff/D35423792)

[ghstack-poisoned]
This was referenced Apr 6, 2022
Closed
Closed
@jerryzh168
Update on "[quant][fx] Move rnn ops to backend_config_dict"
eac2e13 
Summary:
att, similar to previous PRs, this one moves dynamically quantized rnn ops
to backend_config_dict
Currently the dtype check is not yet enabled, so we provided the dtype_configs but it is not really used yet,
we will enable it a bit later after we moved everything to backend_config_dict

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35423792](https://our.internmc.facebook.com/intern/diff/D35423792)

[ghstack-poisoned]
This was referenced Apr 6, 2022
Closed
Closed
Closed
Closed
@jerryzh168
Copy link
Contributor Author

jerryzh168 commented Apr 6, 2022

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@jerryzh168
Update on "[quant][fx] Move rnn ops to backend_config_dict"
129b81e 
Summary:
att, similar to previous PRs, this one moves dynamically quantized rnn ops
to backend_config_dict
Currently the dtype check is not yet enabled, so we provided the dtype_configs but it is not really used yet,
we will enable it a bit later after we moved everything to backend_config_dict

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35423792](https://our.internmc.facebook.com/intern/diff/D35423792)

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request Apr 7, 2022
Closed
@jerryzh168
Update on "[quant][fx] Move rnn ops to backend_config_dict"
a97dba0 
Summary:
att, similar to previous PRs, this one moves dynamically quantized rnn ops
to backend_config_dict
Currently the dtype check is not yet enabled, so we provided the dtype_configs but it is not really used yet,
we will enable it a bit later after we moved everything to backend_config_dict

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D35423792](https://our.internmc.facebook.com/intern/diff/D35423792)

[ghstack-poisoned]
@jerryzh168
Copy link
Contributor Author

jerryzh168 commented Apr 8, 2022

@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Apr 8, 2022
@jerryzh168 @facebook-github-bot
[quant][fx] Move rnn ops to backend_config_dict (#75316)
0247f3a 
Summary:
Pull Request resolved: #75316

att, similar to previous PRs, this one moves dynamically quantized rnn ops
to backend_config_dict
Currently the dtype check is not yet enabled, so we provided the dtype_configs but it is not really used yet,
we will enable it a bit later after we moved everything to backend_config_dict

Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs

Imported from OSS

Reviewed By: malfet

Differential Revision: D35423792

fbshipit-source-id: ef862ea1be5bfb4c28130775c3b2158df28d3e22
@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/774/head branch April 11, 2022 14:17
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

@andrewor14 andrewor14 Awaiting requested review from andrewor14

Assignees

No one assigned

Labels

cla signed module: fx topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @vkuzo