[PT-D] Fix Sharding spec inference to avoid invalid chunk sharding to be inferred as chunkshardingspec #75296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be inferred as chunkshardingspec Our previous logic does not fully all corner cases when it comes to imbalance sharding. For example, one is 16 another one is 9. (This cannot be chunk sharding) because the total length is 25 and if it's chunk sharding, it should be 13 and 12. So we need to get the total length first and calculated the expected chunk length to ensure it's indeed a chunk sharding case. Also added more test cases in unit test. Differential Revision: [D35417257](https://our.internmc.facebook.com/intern/diff/D35417257/) [ghstack-poisoned]
fduwjj
requested review from
H-Huang,
awgu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit afc39ce (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
fduwjj
added a commit
that referenced
this pull request
Apr 6, 2022
… be inferred as chunkshardingspec Our previous logic does not fully all corner cases when it comes to imbalance sharding. For example, one is 16 another one is 9. (This cannot be chunk sharding) because the total length is 25 and if it's chunk sharding, it should be 13 and 12. So we need to get the total length first and calculated the expected chunk length to ensure it's indeed a chunk sharding case. Also added more test cases in unit test. Differential Revision: [D35417257](https://our.internmc.facebook.com/intern/diff/D35417257/) ghstack-source-id: 153136085 Pull Request resolved: #75296
…sharding to be inferred as chunkshardingspec" Our previous logic does not fully all corner cases when it comes to imbalance sharding. For example, one is 16 another one is 9. (This cannot be chunk sharding) because the total length is 25 and if it's chunk sharding, it should be 13 and 12. So we need to get the total length first and calculated the expected chunk length to ensure it's indeed a chunk sharding case. Also added more test cases in unit test. Differential Revision: [D35417257](https://our.internmc.facebook.com/intern/diff/D35417257/) [ghstack-poisoned]
fduwjj
added a commit
that referenced
this pull request
Apr 6, 2022
… be inferred as chunkshardingspec Pull Request resolved: #75296 Our previous logic does not fully all corner cases when it comes to imbalance sharding. For example, one is 16 another one is 9. (This cannot be chunk sharding) because the total length is 25 and if it's chunk sharding, it should be 13 and 12. So we need to get the total length first and calculated the expected chunk length to ensure it's indeed a chunk sharding case. Also added more test cases in unit test. ghstack-source-id: 153190671 Differential Revision: [D35417257](https://our.internmc.facebook.com/intern/diff/D35417257/)
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
… be inferred as chunkshardingspec (#75296) Summary: Pull Request resolved: #75296 Our previous logic does not fully all corner cases when it comes to imbalance sharding. For example, one is 16 another one is 9. (This cannot be chunk sharding) because the total length is 25 and if it's chunk sharding, it should be 13 and 12. So we need to get the total length first and calculated the expected chunk length to ensure it's indeed a chunk sharding case. Also added more test cases in unit test. ghstack-source-id: 153190671 Test Plan: CI Reviewed By: fegin Differential Revision: D35417257 fbshipit-source-id: a7df2183f9747c765498eb460678709b76cdf7b4
Contributor
|
Hey @fduwjj. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Our previous logic does not fully all corner cases when it comes to imbalance sharding. For example, one is 16 another one is 9. (This cannot be chunk sharding) because the total length is 25 and if it's chunk sharding, it should be 13 and 12. So we need to get the total length first and calculated the expected chunk length to ensure it's indeed a chunk sharding case.
Also added more test cases in unit test.
Differential Revision: D35417257