Back out "[shard] use scatter in shard_parameter API" #75295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit changeset: c823c5d0066a Original Phabricator Diff: D33933419 #72160 broke some sharded tensor tests. Let's revert it first and reland it again once the test failure has been fixed. Differential Revision: [D35418031](https://our.internmc.facebook.com/intern/diff/D35418031/) [ghstack-poisoned]
fduwjj
requested review from
H-Huang,
awgu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 19036eb (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
Summary: Pull Request resolved: #75295 Original commit changeset: c823c5d0066a Original Phabricator Diff: D33933419 (288de54) #72160 broke some sharded tensor tests. Let's revert it first and reland it again once the test failure has been fixed. ghstack-source-id: 153135278 (Note: this ignores all push blocking failures!) Test Plan: CI Reviewed By: wanchaol Differential Revision: D35418031 fbshipit-source-id: a4435a62d4487a927d0cf79624afe4f0951809c8
NesrineMHB
pushed a commit
to NesrineMHB/pytorch
that referenced
this pull request
Apr 8, 2022
Original commit changeset: c823c5d0066a Original Phabricator Diff: D33933419 pytorch/pytorch#72160 broke some sharded tensor tests. Let's revert it first and reland it again once the test failure has been fixed. Differential Revision: [D35418031](https://our.internmc.facebook.com/intern/diff/D35418031/) ghstack-source-id: 153135278 Pull Request resolved: pytorch/pytorch#75295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Original commit changeset: c823c5d0066a
Original Phabricator Diff: D33933419
#72160 broke some sharded tensor tests. Let's revert it first and reland it again once the test failure has been fixed.
Differential Revision: D35418031