Skip to content

Make default codegen behavior skip Lower function #75267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wconstab wants to merge 3 commits into from
Closed

Make default codegen behavior skip Lower function #75267

wconstab wants to merge 3 commits into from

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Apr 5, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

  • clean up arguments relating to ts backend generation
  • make entire lowering function rather than just body be a part of
    backend-IR class

Differential Revision: D35411212

@wconstab
Make default codegen behavior skip Lower function
2227806 
- clean up arguments relating to ts backend generation
- make entire lowering function rather than just body be a part of
  backend-IR class

[ghstack-poisoned]
@wconstab wconstab mentioned this pull request Apr 5, 2022
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit a3cb8ed (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-xenial-py3.7-clang7-asan / test (default, 3, 3, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-04-05T22:55:00.6803621Z SUMMARY: Undefined.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
2022-04-05T22:55:00.6284189Z     #10 0x55733d97fc81 in run_mod /home/builder/tkoch/workspace/python_1648536129212/work/Python/pythonrun.c:1037
2022-04-05T22:55:00.6284967Z     #11 0x55733d98ac69 in PyRun_StringFlags /home/builder/tkoch/workspace/python_1648536129212/work/Python/pythonrun.c:961
2022-04-05T22:55:00.6285786Z     #12 0x55733d98accb in PyRun_SimpleStringFlags /home/builder/tkoch/workspace/python_1648536129212/work/Python/pythonrun.c:455
2022-04-05T22:55:00.6286572Z     #13 0x55733d98adc8 in pymain_run_command /home/builder/tkoch/workspace/python_1648536129212/work/Modules/main.c:420
2022-04-05T22:55:00.6287137Z     #14 0x55733d98adc8 in pymain_run_python /home/builder/tkoch/workspace/python_1648536129212/work/Modules/main.c:2907
2022-04-05T22:55:00.6287629Z     #15 0x55733d98adc8 in pymain_main /home/builder/tkoch/workspace/python_1648536129212/work/Modules/main.c:3460
2022-04-05T22:55:00.6287993Z     #16 0x55733d98b18b in _Py_UnixMain /home/builder/tkoch/workspace/python_1648536129212/work/Modules/main.c:3495
2022-04-05T22:55:00.6801982Z     #17 0x7f1056ac383f in __libc_start_main /build/glibc-S7Ft5T/glibc-2.23/csu/../csu/libc-start.c:291
2022-04-05T22:55:00.6802320Z     #18 0x55733d930039 in _start (/opt/conda/bin/python3.7+0x1d8039)
2022-04-05T22:55:00.6802476Z 
2022-04-05T22:55:00.6803621Z SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
2022-04-05T22:55:00.7033248Z + retcode=1
2022-04-05T22:55:00.7033606Z + set -e
2022-04-05T22:55:00.7033901Z + return 1
2022-04-05T22:55:00.7037061Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX-* ]]
2022-04-05T22:55:00.7037363Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X ]]
2022-04-05T22:55:00.7037756Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX2-* ]]
2022-04-05T22:55:00.7038116Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X\2 ]]
2022-04-05T22:55:00.7038487Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX512-* ]]
2022-04-05T22:55:00.7038763Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X\5\1\2 ]]
2022-04-05T22:55:00.7060965Z + [[ linux-xenial-py3.7-clang7-asan-default == *tbb* ]]
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@wconstab
Copy link
Contributor Author

wconstab commented Apr 5, 2022

@antoniojkim Could you adapt to this change on your end? We need to somehow make it possible for XLA team to avoid generating a Lower function for now.

@wconstab wconstab requested review from JackCaoG and bdhirsh April 5, 2022 18:31
@antoniojkim
Copy link
Collaborator

antoniojkim commented Apr 5, 2022 •
edited
Loading

@antoniojkim Could you adapt to this change on your end? We need to somehow make it possible for XLA team to avoid generating a Lower function for now.

yep, I can make this work. Thanks for letting me know of it

bdhirsh
bdhirsh approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@bdhirsh bdhirsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

JackCaoG
JackCaoG approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wconstab wconstab mentioned this pull request Apr 5, 2022
Closed
@wconstab
Copy link
Contributor Author

wconstab commented Apr 5, 2022

@wconstab has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@wconstab
Update on "Make default codegen behavior skip Lower function"
cba1579 
- clean up arguments relating to ts backend generation
- make entire lowering function rather than just body be a part of
  backend-IR class

Differential Revision: [D35411212](https://our.internmc.facebook.com/intern/diff/D35411212)

[ghstack-poisoned]
@wconstab
Copy link
Contributor Author

wconstab commented Apr 5, 2022

@wconstab has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@wconstab
Update on "Make default codegen behavior skip Lower function"
a3cb8ed 
- clean up arguments relating to ts backend generation
- make entire lowering function rather than just body be a part of
  backend-IR class

Differential Revision: [D35411212](https://our.internmc.facebook.com/intern/diff/D35411212)

[ghstack-poisoned]
@wconstab
Copy link
Contributor Author

wconstab commented Apr 5, 2022

@wconstab has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Apr 6, 2022
@wconstab @facebook-github-bot
Make default codegen behavior skip Lower function (#75267)
80a6fa7 
Summary:
Pull Request resolved: #75267

- clean up arguments relating to ts backend generation
- make entire lowering function rather than just body be a part of
  backend-IR class

Test Plan: Imported from OSS

Reviewed By: bdhirsh

Differential Revision: D35411212

Pulled By: wconstab

fbshipit-source-id: 44419e42f706afeb967f704649c2b44e9f66d969
@wconstab wconstab added topic: not user facing topic category release notes: lazy release notes category labels Apr 6, 2022
@facebook-github-bot facebook-github-bot deleted the gh/wconstab/2/head branch April 9, 2022 14:16
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdhirsh bdhirsh bdhirsh approved these changes

@JackCaoG JackCaoG JackCaoG approved these changes

Assignees

No one assigned

Labels

cla signed release notes: lazy release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wconstab @facebook-github-bot @antoniojkim @bdhirsh @JackCaoG