Skip to content

Back out "Extend jit::load to work on flatbuffer file" #75244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
houseroad wants to merge 1 commit into from
Closed

Back out "Extend jit::load to work on flatbuffer file" #75244

houseroad wants to merge 1 commit into from

Conversation

@houseroad
Copy link
Member

@houseroad houseroad commented Apr 5, 2022

Summary:
Original commit changeset: d653a5af662a

Original Phabricator Diff: D35060736 (d9d3492)

Test Plan: Model loading test, verified that D35060736 (d9d3492) will cause the torch::save => torch::load failure.

Reviewed By: yinghai, jianyuh

Differential Revision: D35387009

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Apr 5, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 12b6dd8 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️‍♀️ 1 failure not recognized by patterns:

The following CI failures may be due to changes from the PR
Job Step Action
GitHub Actions pull / linux-xenial-py3.7-gcc7-no-ops / build Checkout PyTorch 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2022

This pull request was exported from Phabricator. Differential Revision: D35387009

@houseroad @facebook-github-bot
Back out "Extend jit::load to work on flatbuffer file" (pytorch#75244)
12b6dd8 
Summary:
Pull Request resolved: pytorch#75244

Original commit changeset: d653a5af662a

Original Phabricator Diff: D35060736 (pytorch@d9d3492)

Test Plan: Model loading test, verified that D35060736 (pytorch@d9d3492) will cause the torch::save => torch::load failure.

Reviewed By: yinghai, jianyuh

Differential Revision: D35387009

fbshipit-source-id: 734b565da9a143d10f5536adaf6b481604c5fbc4
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2022

This pull request was exported from Phabricator. Differential Revision: D35387009

facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
@houseroad @facebook-github-bot
Back out "Extend jit::load to work on flatbuffer file" (#75244)
6c8cc0d 
Summary:
Pull Request resolved: #75244

Original commit changeset: d653a5af662a

Original Phabricator Diff: D35060736 (d9d3492)

Test Plan: Model loading test, verified that D35060736 (d9d3492) will cause the torch::save => torch::load failure.

Reviewed By: yinghai, jianyuh

Differential Revision: D35387009

fbshipit-source-id: 9d176992d402d57779e2af3d905b3c1538335298
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Hey @houseroad.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed fb-exported oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@houseroad @facebook-github-bot