[quant][fx] Move all binary op configs to backend_config_dict #75241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We have a previous PR that enabled operator.add in backend_config_dict, this PR moved the rest binary ops to backend_config_dict. There are some ops left, which are not needed (previously fp16 ops), we will move them in the following PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 5, 2022
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b665a35 (more details on the Dr. CI page):
🕵️♀️ 1 failure not recognized by patterns:The following CI failures may be due to changes from the PR
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
jerryzh168
added a commit
that referenced
this pull request
Apr 5, 2022
Summary: We have a previous PR that enabled operator.add in backend_config_dict, this PR moved the rest binary ops to backend_config_dict. There are some ops left, which are not needed (previously fp16 ops), we will move them in the following PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9ee7e35 Pull Request resolved: #75241
vkuzo
reviewed
Apr 5, 2022
vkuzo
approved these changes
Apr 5, 2022
andrewor14
approved these changes
Apr 5, 2022
…ict" Summary: We have a previous PR that enabled operator.add in backend_config_dict, this PR moved the rest binary ops to backend_config_dict. There are some ops left, which are not needed (previously fp16 ops), we will move them in the following PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 5, 2022
…ict" Summary: We have a previous PR that enabled operator.add in backend_config_dict, this PR moved the rest binary ops to backend_config_dict. There are some ops left, which are not needed (previously fp16 ops), we will move them in the following PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…ict" Summary: We have a previous PR that enabled operator.add in backend_config_dict, this PR moved the rest binary ops to backend_config_dict. There are some ops left, which are not needed (previously fp16 ops), we will move them in the following PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…ict" Summary: We have a previous PR that enabled operator.add in backend_config_dict, this PR moved the rest binary ops to backend_config_dict. There are some ops left, which are not needed (previously fp16 ops), we will move them in the following PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35403589](https://our.internmc.facebook.com/intern/diff/D35403589) [ghstack-poisoned]
This was referenced Apr 6, 2022
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
Summary: Pull Request resolved: #75241 We have a previous PR that enabled operator.add in backend_config_dict, this PR moved the rest binary ops to backend_config_dict. There are some ops left, which are not needed (previously fp16 ops), we will move them in the following PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Imported from OSS Reviewed By: bdhirsh Differential Revision: D35403589 fbshipit-source-id: 663703b310944a6b7c5ade6d07a4d938a6ca082b
…ict" Summary: We have a previous PR that enabled operator.add in backend_config_dict, this PR moved the rest binary ops to backend_config_dict. There are some ops left, which are not needed (previously fp16 ops), we will move them in the following PR Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps python test/test_quantization.py TestFXNumericSuiteCoreAPIs Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35403589](https://our.internmc.facebook.com/intern/diff/D35403589) [ghstack-poisoned]
This was referenced Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
We have a previous PR that enabled operator.add in backend_config_dict, this
PR moved the rest binary ops to backend_config_dict.
There are some ops left, which are not needed (previously fp16 ops), we
will move them in the following PR
Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
python test/test_quantization.py TestFXNumericSuiteCoreAPIs
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D35403589