Skip to content

Fix lazy ts backend build flags #75237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wconstab wants to merge 1 commit into from
Closed

Fix lazy ts backend build flags #75237

wconstab wants to merge 1 commit into from

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Apr 4, 2022

Summary: applies 'OVRSOURCE' logic to one more place missed in D35331263 (8b7e2bf) so that lazy TS backend is not compiled in internal builds

Test Plan: CI

Differential Revision: D35377758

@wconstab @facebook-github-bot
Fix lazy ts backend build flags
71debe6 
Summary: applies 'OVRSOURCE' logic to one more place missed in D35331263 (pytorch@8b7e2bf) so that lazy TS backend is not compiled in internal builds

Test Plan: CI

Differential Revision: D35377758

fbshipit-source-id: 6981f51fcc507aa0162edd1ac5fe9837054bf8cb
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 4, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 71debe6 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 4, 2022

This pull request was exported from Phabricator. Differential Revision: D35377758

facebook-github-bot pushed a commit that referenced this pull request Apr 4, 2022
@wconstab @facebook-github-bot
Fix lazy ts backend build flags (#75237)
8b8ed7b 
Summary:
Pull Request resolved: #75237

applies 'OVRSOURCE' logic to one more place missed in D35331263 (8b7e2bf) so that lazy TS backend is not compiled in internal builds

Test Plan: CI

Reviewed By: malfet, shunting314

Differential Revision: D35377758

fbshipit-source-id: 5dcd3d36e50a8917470a917f2120353972dc31ba
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Hey @wconstab.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@wconstab wconstab added cherry-picked This PR was cherry-picked onto a release branch from master topic: not user facing topic category release notes: lazy release notes category labels Apr 5, 2022
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cherry-picked This PR was cherry-picked onto a release branch from master cla signed fb-exported release notes: lazy release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wconstab @facebook-github-bot