Fix casting bug for state['step'] of optimizers when loading state dict #75214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 41225a7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
mikaylagawarecki
changed the title
albanD
approved these changes
Apr 4, 2022
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
From offline discussion.
This is an ok localized fix for the most pressing matter. We will open an issue an investigate a better general solution.
Contributor
Author
|
@pytorchbot merge this please |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
…75214) Summary: Pull Request resolved: #75214 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/10bb0ffe698b51ce8f11fa0ab3870bac10d96072 Reviewed By: b0noI Differential Revision: D35404323 Pulled By: mikaylagawarecki fbshipit-source-id: ea797028bd67b535d607eb0b3ddf946685037263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fix #74424