Skip to content

masked argmin/argmax #75212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
george-qi wants to merge 2 commits into from
Closed

masked argmin/argmax #75212

george-qi wants to merge 2 commits into from

Conversation

@george-qi
Copy link
Contributor

@george-qi george-qi commented Apr 4, 2022 •
edited
Loading

@george-qi
masked argmin/argmax
6858022 
[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 4, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 9d1c3aa (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

george-qi added a commit that referenced this pull request Apr 4, 2022
@george-qi
masked argmin/argmax
8182322 
ghstack-source-id: f3500e6
Pull Request resolved: #75212
@george-qi george-qi added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 4, 2022
@george-qi
Copy link
Contributor Author

george-qi commented Apr 4, 2022

@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

george-qi added a commit that referenced this pull request Apr 4, 2022
@george-qi
masked argmin/argmax
b4b1a83 
ghstack-source-id: 3e23859
Pull Request resolved: #75212
@cpuhrsch cpuhrsch self-requested a review April 5, 2022 18:49
@cpuhrsch
Copy link
Contributor

cpuhrsch commented Apr 5, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Hey @george-qi.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@cpuhrsch cpuhrsch added the topic: not user facing topic category label Apr 5, 2022
facebook-github-bot pushed a commit that referenced this pull request Apr 7, 2022
@george-qi @facebook-github-bot
masked argmin/argmax (#75212)
5006c80 
Summary:
Pull Request resolved: #75212

Approved by: https://github.com/cpuhrsch

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e5a1a78045e66aad9e763bf69c2455f8136c1eef

Reviewed By: b0noI

Differential Revision: D35435900

Pulled By: george-qi

fbshipit-source-id: d2ef6d321e58ebf9997b71a4534ac6213e1aa0d0
@facebook-github-bot facebook-github-bot deleted the gh/george-qi/31/head branch April 8, 2022 23:01
@george-qi george-qi mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@george-qi @facebook-github-bot @cpuhrsch