[quant][fx] Remove Standalone and CustomModule QuantizeHandler type checks in prepare #75202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hecks in prepare Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Apr 4, 2022
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b20ce46 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 4, 2022
…hecks in prepare Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 7a9640d Pull Request resolved: #75202
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35379641](https://our.internmc.facebook.com/intern/diff/D35379641) [ghstack-poisoned]
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35379641](https://our.internmc.facebook.com/intern/diff/D35379641) [ghstack-poisoned]
vkuzo
approved these changes
Apr 5, 2022
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35379641](https://our.internmc.facebook.com/intern/diff/D35379641) [ghstack-poisoned]
This was referenced Apr 5, 2022
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35379641](https://our.internmc.facebook.com/intern/diff/D35379641) [ghstack-poisoned]
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35379641](https://our.internmc.facebook.com/intern/diff/D35379641) [ghstack-poisoned]
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
…dler type checks in prepare" Summary: Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D35379641](https://our.internmc.facebook.com/intern/diff/D35379641) [ghstack-poisoned]
This was referenced Apr 6, 2022
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
…hecks in prepare (#75202) Summary: Pull Request resolved: #75202 Instead of checking the type we use a method in the QuantizeHandler to check if a module is a standalone or custom module, not user facing Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Imported from OSS Reviewed By: bdhirsh Differential Revision: D35379641 fbshipit-source-id: c2f970c7e27f74793fa67f8fd5a16a43525e35aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Instead of checking the type we use a method in the QuantizeHandler to check if a module
is a standalone or custom module, not user facing
Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D35379641