[quant][fx] Fix lowering pass for cases when to is not called with positional args
#75146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…positional args Summary: Previously we assume `to` must be called with positioanl args, but this may not be the case, e.g. we can do `to(dtype=?)` or `to(memory_format=?)` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit f626869 (more details on the Dr. CI page):
🕵️♀️ 1 failure not recognized by patterns:The following CI failures may be due to changes from the PR
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
…alled with positional args" Summary: Previously we assume `to` must be called with positioanl args, but this may not be the case, e.g. we can do `to(dtype=?)` or `to(memory_format=?)` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Apr 2, 2022
…positional args Summary: Previously we assume `to` must be called with positioanl args, but this may not be the case, e.g. we can do `to(dtype=?)` or `to(memory_format=?)` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: f6a4f90 Pull Request resolved: #75146
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
andrewor14
approved these changes
Apr 4, 2022
| is_quantize = q_node.target == torch.quantize_per_tensor | ||
| is_to_fp16 = q_node.op == "call_method" and q_node.target == "to" and q_node.args[1] == torch.float16 | ||
| is_to_fp16 = q_node.op == "call_method" and q_node.target == "to" and \ | ||
| len(q_node.args) == 2 and q_node.args[1] == torch.float16 |
Contributor
There was a problem hiding this comment.
Did this fail with array out of bounds exception before with keyword args?
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 4, 2022
…positional args (#75146) Summary: Pull Request resolved: #75146 Previously we assume `to` must be called with positioanl args, but this may not be the case, e.g. we can do `to(dtype=?)` or `to(memory_format=?)` Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Imported from OSS Reviewed By: ejguan Differential Revision: D35342088 fbshipit-source-id: 22bfe78ae84e74141ae6560285c5c38bc068c999
Contributor
|
Hey @jerryzh168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
tois not called with positional args #75146Summary:
Previously we assume
tomust be called with positioanl args, but this may not be the case,e.g. we can do
to(dtype=?)orto(memory_format=?)Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D35342088