Add Parsing of tensor constants #75119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 409350d (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
ZolotukhinM
approved these changes
Apr 1, 2022
ZolotukhinM
left a comment
ZolotukhinM
left a comment
There was a problem hiding this comment.
This is supernice, thanks! A couple of remarks below:
torch/csrc/jit/ir/irparser.cpp
Outdated
| std::unordered_map<std::string, Value*>& vmap; | ||
| SchemaTypeParser type_parser; | ||
| bool parse_tensor_constants_; | ||
| std::unordered_set<Node*> deferred_tensor_value_initializations_; |
There was a problem hiding this comment.
Using unordered_set here would result in non-determinism. Would it be possible to somehow fix it? We might also want to have some control knob over the random values we use for initialization for the same reason.
Add support for parsing Tensor constants like Double(4, 4) ... by initializing random tensors. This makes saving IR and then parsing it lossy, so I have it toggled as default not on, but is useful in cases like repro-ing Fusions with tensor constants post-freezing. cc @Krovatkin [ghstack-poisoned]
Contributor
Author
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Add support for parsing Tensor constants like Double(4, 4) ... by initializing random tensors. This makes saving IR and then parsing it lossy, so I have it toggled as default not on, but is useful in cases like repro-ing Fusions with tensor constants post-freezing. cc @Krovatkin Differential Revision: [D35373999](https://our.internmc.facebook.com/intern/diff/D35373999) [ghstack-poisoned]
Contributor
Author
|
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
Summary: Pull Request resolved: #75119 Add support for parsing Tensor constants like Double(4, 4) ... by initializing random tensors. This makes saving IR and then parsing it lossy, so I have it toggled as default not on, but is useful in cases like repro-ing Fusions with tensor constants post-freezing. cc Krovatkin Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D35373999 Pulled By: eellison fbshipit-source-id: a5c8d9f93f23a7442258fc745ed6b6def330dca8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Add support for parsing Tensor constants like Double(4, 4) ... by initializing random tensors. This makes saving IR and then parsing it lossy, so I have it toggled as default not on, but is useful in cases like repro-ing Fusions with tensor constants post-freezing.
cc @Krovatkin
Differential Revision: D35373999