Skip to content

[Easy][FSDP] Update full osd warning #75109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
awgu wants to merge 2 commits into from
Closed

[Easy][FSDP] Update full osd warning #75109

awgu wants to merge 2 commits into from

Conversation

@awgu
Copy link
Collaborator

@awgu awgu commented Apr 1, 2022 •
edited
Loading

Stack from ghstack:

Clarify that only rank 0 receives a populated optimizer state dict to avoid confusion.

Differential Revision: D35319158

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 1, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 7182b92 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Apr 1, 2022
awgu pushed a commit that referenced this pull request Apr 1, 2022
[Easy][FSDP] Update full osd warning
c676100 
ghstack-source-id: a4989e3
Pull Request resolved: #75109
@awgu
Copy link
Collaborator Author

awgu commented Apr 1, 2022

@awgu has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Apr 2, 2022
@facebook-github-bot
[Easy][FSDP] Update full osd warning (#75109)
7c1d719 
Summary:
Pull Request resolved: #75109

Clarify that only rank 0 receives a populated optimizer state dict to avoid confusion.

Test Plan: Imported from OSS

Reviewed By: mruberry

Differential Revision: D35319158

Pulled By: awgu

fbshipit-source-id: f8d5d4b5d94a6ffd89a42c0e63f40e920d3c07ad
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Hey @awgu.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/awgu/21/head branch April 5, 2022 14:17
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaojuanmao zhaojuanmao zhaojuanmao approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@H-Huang H-Huang Awaiting requested review from H-Huang

Assignees

No one assigned

Labels

cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@awgu @facebook-github-bot @zhaojuanmao