Add -Wsign-compare to list of clang flags
#75085
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It caused a number of internal only compilation failures, for example see: #74425 (comment) and #74542 (comment) [ghstack-poisoned]
This was referenced Apr 1, 2022
Closed
This was referenced Apr 1, 2022
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit bb32724 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
malfet
added a commit
that referenced
this pull request
Apr 1, 2022
It caused a number of internal only compilation failures, for example see: #74425 (comment) and #74542 (comment) ghstack-source-id: 70e3ddd Pull Request resolved: #75085
It caused a number of internal only compilation failures, for example see: #74425 (comment) and #74542 (comment) [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Apr 2, 2022
It caused a number of internal only compilation failures, for example see: #74425 (comment) and #74542 (comment) ghstack-source-id: 8db31ff Pull Request resolved: #75085
ngimel
approved these changes
Apr 4, 2022
It caused a number of internal only compilation failures, for example see: #74425 (comment) and #74542 (comment) [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Apr 5, 2022
It caused a number of internal only compilation failures, for example see: #74425 (comment) and #74542 (comment) ghstack-source-id: 14889fa Pull Request resolved: #75085
albanD
approved these changes
Apr 5, 2022
Contributor
Author
|
@pytorchbot merge this |
Contributor
|
Hey @malfet. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 7, 2022
Summary: It caused a number of internal only compilation failures, for example see: #74425 (comment) and #74542 (comment) Pull Request resolved: #75085 Approved by: https://github.com/ngimel, https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/90a56fc515dbac9534a1a14110f9edf089430f81 Reviewed By: b0noI Differential Revision: D35404322 Pulled By: malfet fbshipit-source-id: aaa7033d0b7cbfcc1d4b3eeff86d09eba428f068
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
-Wsign-compareto list of clang flags #75085It caused a number of internal only compilation failures, for example
see:
#74425 (comment)
and #74542 (comment)