Skip to content

Fix sign-compare in caffe2 cpp tests #75084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 2 commits into from
Closed

Fix sign-compare in caffe2 cpp tests #75084

malfet wants to merge 2 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Apr 1, 2022 •
edited
Loading

@malfet
Fix sign-compare in caffe2 cpp tests
7e6870b 
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo

[ghstack-poisoned]
@malfet malfet mentioned this pull request Apr 1, 2022
Closed
@malfet malfet mentioned this pull request Apr 1, 2022
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 1, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit bf3aa8b (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Apr 1, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@malfet
Update on "Fix sign-compare in caffe2 cpp tests"
bf3aa8b 
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo

[ghstack-poisoned]
@malfet
Copy link
Contributor Author

malfet commented Apr 5, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 6, 2022
@malfet @facebook-github-bot
Fix sign-compare in caffe2 cpp tests (#75084)
e8b51de 
Summary:
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo

Pull Request resolved: #75084

Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f6e7a2ab640d96667a414c9ddc925c1d146aa0ba

Reviewed By: b0noI

Differential Revision: D35404321

Pulled By: malfet

fbshipit-source-id: 3b0ac3b7a76e2d2d4b9ed23a2d020049a83ca7e4
@malfet malfet mentioned this pull request Apr 6, 2022
Closed
@facebook-github-bot facebook-github-bot deleted the gh/malfet/48/head branch April 8, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @facebook-github-bot @ngimel