Fix sign-compare in c10d/Utils.hpp
#75081
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo [ghstack-poisoned]
malfet
requested review from
H-Huang,
awgu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
This was referenced Apr 1, 2022
Closed
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 47388c7 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
This was referenced Apr 1, 2022
atalman
approved these changes
Apr 2, 2022
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
Summary: Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo Pull Request resolved: #75081 Approved by: https://github.com/atalman Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/ef56497ea003e6059b081f8876700cddbe29b882 Reviewed By: b0noI Differential Revision: D35404314 Pulled By: malfet fbshipit-source-id: 8700e88b4b42a25bb9efb7c727376735cfbc9999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
-Wsign-compareto list of clang flags #75085c10d/Utils.hpp#75081Prerequisite change for enabling
-Werror=sign-compareacross PyTorch repo