Skip to content

Fix sign-compare violations in cpp tests #75080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 2 commits into from
Closed

Fix sign-compare violations in cpp tests #75080

malfet wants to merge 2 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Apr 1, 2022 •
edited
Loading

@malfet
Fix sign-compare violations in cpp tests
55244d1 
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo

[ghstack-poisoned]
@malfet malfet mentioned this pull request Apr 1, 2022
Closed
This was referenced Apr 1, 2022
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 1, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit ff23489 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet mentioned this pull request Apr 1, 2022
Closed
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 1, 2022
This was referenced Apr 1, 2022
Closed
Closed
Closed
Closed
Closed
Closed
@malfet malfet requested a review from iseeyuan April 2, 2022 00:16
atalman
atalman approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malfet
Update on "Fix sign-compare violations in cpp tests"
ff23489 
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo

[ghstack-poisoned]
@malfet
Copy link
Contributor Author

malfet commented Apr 4, 2022

@pytorchbot merge this

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 4, 2022

Merge failed due to Matched rule superuser, but it was not reviewed yet by any of:mruberry,PaliC,aaronenyeshi,angelayi,desertfire, ...
Raised by https://github.com/pytorch/pytorch/actions/runs/2090531968

@malfet
Copy link
Contributor Author

malfet commented Apr 4, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 5, 2022
@malfet @facebook-github-bot
Fix sign-compare violations in cpp tests (#75080)
5107c75 
Summary:
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo

Pull Request resolved: #75080

Approved by: https://github.com/atalman

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/81d765ef1f7acdc83d81c4400071e38cae69f100

Reviewed By: b0noI

Differential Revision: D35404307

Pulled By: malfet

fbshipit-source-id: fd499c120ddf0d78cccc9e482cdd2a707960251b
@facebook-github-bot facebook-github-bot deleted the gh/malfet/44/head branch April 8, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@iseeyuan iseeyuan Awaiting requested review from iseeyuan

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @facebook-github-bot @pytorchmergebot @atalman