Fix sign-compare violations in torch_python #75079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 503ebab (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Apr 1, 2022
Closed
albanD
reviewed
Apr 1, 2022
torch/csrc/utils/tensor_numpy.cpp
Outdated
| PyObject *py_strides = PyDict_GetItemString(cuda_dict, "strides"); | ||
| if (py_strides != nullptr && py_strides != Py_None) { | ||
| if (PySequence_Length(py_strides) == -1 || PySequence_Length(py_strides) != sizes.size()) { | ||
| if (PySequence_Length(py_strides) == -1 || PySequence_Length(py_strides) != static_cast<Py_ssize_t>(sizes.size())) { |
Collaborator
There was a problem hiding this comment.
Don't we prefer to cast the result of PySequence_Length to size_t?
From a quick search, looks like Py_ssize_t is a int only.
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
Summary: Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo Pull Request resolved: #75079 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/c593c220ff8ecbadf065acc1bd74661bba2dc2bf Reviewed By: seemethere, b0noI Differential Revision: D35404324 Pulled By: malfet fbshipit-source-id: ae08bf80fd280d0e7aca96a4747dbc888ec4adb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
-Wsign-compareto list of clang flags #75085c10d/Utils.hpp#75081Prerequisite change for enabling
-Werror=sign-compareacross PyTorch repo