Skip to content

irangefy ONNX #75078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

irangefy ONNX #75078

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Apr 1, 2022 •
edited
Loading

@malfet
irangefy ONNX
e74355e 
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo

[ghstack-poisoned]
This was referenced Apr 1, 2022
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 1, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit e74355e (more details on the Dr. CI page):

  • 2/2 failures introduced in this PR

🕵️‍♀️ 2 failures not recognized by patterns:

The following CI failures may be due to changes from the PR
Job Step Action
GitHub Actions pull / linux-bionic-rocm5.0-py3.7 / test (default, 2, 2, linux.rocm.gpu) Checkout PyTorch 🔁 rerun
GitHub Actions pull / linux-bionic-rocm5.0-py3.7 / test (default, 1, 2, linux.rocm.gpu) Checkout PyTorch 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Apr 1, 2022
malfet added a commit that referenced this pull request Apr 1, 2022
@malfet
irangefy ONNX
8134ae0 
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo

ghstack-source-id: deea4af
Pull Request resolved: #75078
This was referenced Apr 1, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@malfet
Copy link
Contributor Author

malfet commented Apr 1, 2022

@pytorchbot merge this

@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 4, 2022
@malfet @facebook-github-bot
irangefy ONNX (#75078)
9307451 
Summary:
Prerequisite change for enabling `-Werror=sign-compare` across PyTorch repo

Pull Request resolved: #75078

Approved by: https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/adee867c8da044b9da132b3eb2a2dda296940e9c

Reviewed By: atalman

Differential Revision: D35359952

Pulled By: malfet

fbshipit-source-id: a39b3fb3039e98cdda9abbcad7692a68274ea824
@facebook-github-bot facebook-github-bot deleted the gh/malfet/42/head branch April 5, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BowenBao BowenBao BowenBao approved these changes

@shubhambhokare1 shubhambhokare1 Awaiting requested review from shubhambhokare1

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @facebook-github-bot @BowenBao