[quant] Always match the first matchable pattern in fuse #75047
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As title, For instance, We match two patterns ``` (add, (bn, conv), matchallnode) (add, matchallnode, (bn, conv)) ``` Against the model ``` conv1 -> bn1 | conv2 -> bn2 + add ``` For the add node, both two patterns passes `is_match` and `apply_match` is executed twice. As a result, both `conv1 -> bn1` and `conv2 -> bn2` will be matched as `(bn, conv)` instead of one `(bn, conv)` one `matchallnode`. To fix this, stop trying all the other pattners once a pattern is matched. Test Plan: verified in D35252100 Differential Revision: D35300191 fbshipit-source-id: e0780802b990815d7c131bf1df6cd12a9022bd96
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c7ce503 (more details on the Dr. CI page):
🕵️♀️ 2 failures not recognized by patterns:The following CI failures may be due to changes from the PR
This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35300191 |
jerryzh168
approved these changes
Mar 31, 2022
Contributor
jerryzh168
left a comment
jerryzh168
left a comment
There was a problem hiding this comment.
thanks for finding the issue and the fix!
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 1, 2022
Summary: Pull Request resolved: #75047 As title, For instance, We match two patterns ``` (add, (bn, conv), matchallnode) (add, matchallnode, (bn, conv)) ``` Against the model ``` conv1 -> bn1 | conv2 -> bn2 + add ``` For the add node, both two patterns passes `is_match` and `apply_match` is executed twice. As a result, both `conv1 -> bn1` and `conv2 -> bn2` will be matched as `(bn, conv)` instead of one `(bn, conv)` one `matchallnode`. To fix this, stop trying all the other pattners once a pattern is matched. Test Plan: verified in D35252100 Reviewed By: jerryzh168 Differential Revision: D35300191 fbshipit-source-id: 383b2eb971d436072e1c28597c5b6a01d0f49c5a
Contributor
|
Hey @LiamZhuuu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As title, For instance,
We match two patterns
Against the model
For the add node, both two patterns passes
is_matchandapply_matchis executed twice. As a result, bothconv1 -> bn1andconv2 -> bn2will be matched as(bn, conv)instead of one(bn, conv)onematchallnode.To fix this, stop trying all the other pattners once a pattern is matched.
Test Plan: verified in D35252100
Differential Revision: D35300191