Skip to content

Extend jit::load to work on flatbuffer file #75022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pavithranrao wants to merge 2 commits into from
Closed

Extend jit::load to work on flatbuffer file #75022

pavithranrao wants to merge 2 commits into from

Conversation

@pavithranrao
Copy link
Contributor

@pavithranrao pavithranrao commented Mar 31, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Extending torch::jit::load to read flatbuffer file

Differential Revision: D35060736

NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!

@pavithranrao
Extend jit::load to work on flatbuffer file
75cdab5 
Extending torch::jit::load to read flatbuffer file

Differential Revision: [D35060736](https://our.internmc.facebook.com/intern/diff/D35060736/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35060736/)!

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 31, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 34c0b64 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-rocm5.0-py3.7 / test (default, 2, 2, linux.rocm.gpu) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-04-01T19:07:20.1145227Z FAIL [0.021s]: tes...id_sampler_cuda (__main__.TestTorchDeviceTypeCUDA) 
2022-04-01T19:07:20.0969808Z   test_where_scalar_valid_combination_cuda_int32 (__main__.TestTorchDeviceTypeCUDA) ... ok (0.003s)
2022-04-01T19:07:20.1068582Z   test_where_scalar_valid_combination_cuda_int64 (__main__.TestTorchDeviceTypeCUDA) ... ok (0.010s)
2022-04-01T19:07:20.1101063Z   test_where_scalar_valid_combination_cuda_int8 (__main__.TestTorchDeviceTypeCUDA) ... ok (0.003s)
2022-04-01T19:07:20.1134943Z   test_where_scalar_valid_combination_cuda_uint8 (__main__.TestTorchDeviceTypeCUDA) ... ok (0.003s)
2022-04-01T19:07:20.1139638Z   test_cuda_vitals_gpu_only_cuda (__main__.TestVitalSignsCudaCUDA) ... [TORCH_VITAL] Dataloader.enabled		 True
2022-04-01T19:07:20.1141113Z [TORCH_VITAL] Dataloader.basic_unit_test		 TEST_VALUE_STRING
2022-04-01T19:07:20.1142837Z [TORCH_VITAL] CUDA.used		 true
2022-04-01T19:07:20.1143563Z ok (0.001s)
2022-04-01T19:07:20.1143917Z 
2022-04-01T19:07:20.1144238Z ======================================================================
2022-04-01T19:07:20.1145227Z FAIL [0.021s]: test_invalid_shapes_grid_sampler_cuda (__main__.TestTorchDeviceTypeCUDA)
2022-04-01T19:07:20.1146885Z ----------------------------------------------------------------------
2022-04-01T19:07:20.1148343Z RuntimeError: cudnn_grid_sampler_forward: ATen not compiled with cuDNN support
2022-04-01T19:07:20.1148967Z 
2022-04-01T19:07:20.1149435Z During handling of the above exception, another exception occurred:
2022-04-01T19:07:20.1150008Z 
2022-04-01T19:07:20.1150310Z Traceback (most recent call last):
2022-04-01T19:07:20.1151743Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 1780, in wrapper
2022-04-01T19:07:20.1152699Z     method(*args, **kwargs)
2022-04-01T19:07:20.1154136Z   File "/opt/conda/lib/python3.7/site-packages/torch/testing/_internal/common_device_type.py", line 376, in instantiated_test
2022-04-01T19:07:20.1155178Z     result = test(self, **param_kwargs)
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Mar 31, 2022
This was referenced Mar 31, 2022
Closed
Closed
pavithranrao added a commit that referenced this pull request Mar 31, 2022
@pavithranrao
Extend jit::load to work on flatbuffer file
36cbf3a 
Extending torch::jit::load to read flatbuffer file

Differential Revision: [D35060736](https://our.internmc.facebook.com/intern/diff/D35060736/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35060736/)!

ghstack-source-id: 152665232
Pull Request resolved: #75022
@pavithranrao pavithranrao mentioned this pull request Mar 31, 2022
Closed
@pavithranrao
Update on "Extend jit::load to work on flatbuffer file"
34c0b64 
Extending torch::jit::load to read flatbuffer file

Differential Revision: [D35060736](https://our.internmc.facebook.com/intern/diff/D35060736/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35060736/)!

[ghstack-poisoned]
pavithranrao added a commit that referenced this pull request Apr 1, 2022
@pavithranrao
Extend jit::load to work on flatbuffer file
75c27c8 
Pull Request resolved: #75022

Extending torch::jit::load to read flatbuffer file
ghstack-source-id: 152820697

Differential Revision: [D35060736](https://our.internmc.facebook.com/intern/diff/D35060736/)

**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D35060736/)!
@pavithranrao pavithranrao requested review from iseeyuan and qihqi April 1, 2022 19:00
iseeyuan
iseeyuan approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@iseeyuan iseeyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

facebook-github-bot pushed a commit that referenced this pull request Apr 2, 2022
@pavithranrao @facebook-github-bot
Extend jit::load to work on flatbuffer file (#75022)
109e14a 
Summary:
Pull Request resolved: #75022

Extending torch::jit::load to read flatbuffer file
ghstack-source-id: 152820697

Test Plan: CI

Reviewed By: iseeyuan

Differential Revision: D35060736

fbshipit-source-id: d653a5af662a46107ff4fd70209fd2a0a4d40f20
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Hey @pavithranrao.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2022

This pull request has been reverted by 32e58c7. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

@facebook-github-bot facebook-github-bot deleted the gh/pavithranrao/56/head branch April 5, 2022 14:17
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2022

This pull request has been reverted by 42ae19b4c85f5bfce5f07c24f0d252a043b0460d. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iseeyuan iseeyuan iseeyuan approved these changes

@qihqi qihqi Awaiting requested review from qihqi

Assignees

No one assigned

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue Reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pavithranrao @facebook-github-bot @iseeyuan