[static-runtime] optimize empty if blocks at runtime #74987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

tenpercent wants to merge 1 commit into pytorch:master from tenpercent:export-D35262952

Collaborator

tenpercent commented Mar 30, 2022

Summary: Add specializations to prim::If operator at runtime to save resources when some of subblocks are empty

Test Plan:
buck build //caffe2:torch-cpp-cpu
buck test //caffe2/benchmarks/static_runtime/...
Add unit test:
buck test //caffe2/benchmarks/static_runtime:static_runtime_cpptest -- StaticRuntime.EmptyIfBlock

Differential Revision: D35262952

facebook-github-bot added the cla signed label

Contributor

facebook-github-bot commented Mar 30, 2022 •

edited

Loading

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/74987
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

💊 CI failures summary and remediations

As of commit 3d35341 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot added oncall: jit fb-exported labels

Contributor

facebook-github-bot commented Mar 30, 2022

This pull request was exported from Phabricator. Differential Revision: D35262952

tenpercent force-pushed the export-D35262952 branch from 69d7c6f to ed10193 Compare

March 30, 2022 23:45

Contributor

facebook-github-bot commented Mar 30, 2022

This pull request was exported from Phabricator. Differential Revision: D35262952

tenpercent force-pushed the export-D35262952 branch from ed10193 to bcb0b83 Compare

March 31, 2022 00:04

Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35262952

1 similar comment

Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35262952

tenpercent force-pushed the export-D35262952 branch from bcb0b83 to ffca382 Compare

March 31, 2022 03:45

Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35262952

tenpercent force-pushed the export-D35262952 branch from ffca382 to 9c72871 Compare

March 31, 2022 16:28

Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35262952

tenpercent force-pushed the export-D35262952 branch from 9c72871 to 0940ba9 Compare

March 31, 2022 17:11


          [static-runtime] optimize empty if blocks at runtime (pytorch#74987)

3d35341

Summary:
Pull Request resolved: pytorch#74987

Add specializations to `prim::If` operator at runtime to save resources when some of subblocks are empty

Test Plan:
`buck build //caffe2:torch-cpp-cpu`
`buck test //caffe2/benchmarks/static_runtime/...`
Add unit test:
`buck test //caffe2/benchmarks/static_runtime:static_runtime_cpptest -- StaticRuntime.EmptyIfBlock`

Differential Revision: D35262952

fbshipit-source-id: 5f2616e39d87c4175693a9e32dd82c698bdb45c4

Contributor

facebook-github-bot commented Mar 31, 2022

This pull request was exported from Phabricator. Differential Revision: D35262952

tenpercent force-pushed the export-D35262952 branch from 0940ba9 to 3d35341 Compare

March 31, 2022 21:05

facebook-github-bot pushed a commit that referenced this pull request


          [static-runtime] optimize empty if blocks at runtime (#74987)

2db1b1a

Summary:
Pull Request resolved: #74987

Add specializations to `prim::If` operator at runtime to save resources when some of subblocks are empty

Test Plan:
`buck build //caffe2:torch-cpp-cpu`
`buck test //caffe2/benchmarks/static_runtime/...`
Add unit test:
`buck test //caffe2/benchmarks/static_runtime:static_runtime_cpptest -- StaticRuntime.EmptyIfBlock`

Reviewed By: mikeiovine

Differential Revision: D35262952

fbshipit-source-id: 324f88471f33f035f4d8a9b212716530d8e59df2

pytorchmergebot closed this in

11c412a

Contributor

github-actions bot commented Apr 1, 2022

Hey @tenpercent.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

WBobby mentioned this pull request

Add ROCm5.2.3/AMDGPU support for PyTorch WBobby/pytorch#2

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed fb-exported oncall: jit