Skip to content

Shape functions: Use friendlier clamping pattern #74980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
silvasean wants to merge 1 commit into from
Closed

Shape functions: Use friendlier clamping pattern #74980

silvasean wants to merge 1 commit into from

Conversation

@silvasean
Copy link
Contributor

@silvasean silvasean commented Mar 30, 2022

When start_val == 0, using the comparison start_val > self[dim] can be folded easily (0 is never strictly greater than the result of self[dim]), but start_val >= self[dim] can't. Since we assign start_val = sef[dim] in the body anyway, both these are equivalent

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 4120276 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@silvasean
Copy link
Contributor Author

silvasean commented Mar 30, 2022

cc @eellison @makslevental

@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Mar 30, 2022
@eellison eellison self-requested a review March 31, 2022 18:40
@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 1, 2022
@eellison
Copy link
Contributor

eellison commented Apr 4, 2022

@pytorchbot rebase this please

eellison
eellison approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! LGTM

@eellison
Copy link
Contributor

eellison commented Apr 4, 2022

hmm, looks like pytorch bot rebase is not a thing, mind rebasing ?

@silvasean
Shape functions: Use friendlier clamping pattern
4120276 
When start_val == 0, using the comparison `start_val > self[dim]` can be folded easily (0 is never strictly greater than the result of `self[dim]`), but `start_val >= self[dim]` can't. Since we assign `start_val = sef[dim]` in the body anyway, both these are equivalent
@silvasean
Copy link
Contributor Author

silvasean commented Apr 4, 2022

Just updated it.

@eellison
Copy link
Contributor

eellison commented Apr 5, 2022

@pytorchbot merge this please

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Hey @silvasean.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 7, 2022
@silvasean @facebook-github-bot
Shape functions: Use friendlier clamping pattern (#74980)
a12c679 
Summary:
When start_val == 0, using the comparison `start_val > self[dim]` can be folded easily (0 is never strictly greater than the result of `self[dim]`), but `start_val >= self[dim]` can't. Since we assign `start_val = sef[dim]` in the body anyway, both these are equivalent

Pull Request resolved: #74980
Approved by: https://github.com/eellison

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/640c1be9006c5416887ff66ff2961eb530983d17

Reviewed By: b0noI

Differential Revision: D35404318

fbshipit-source-id: 7fc949b1100da06e6e09c3b9a22e0fdaa91e8322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eellison eellison eellison approved these changes

Assignees

@eellison eellison

Labels

cla signed oncall: jit Add this issue/PR to JIT oncall triage queue open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@silvasean @facebook-github-bot @eellison @dagitses @pytorchbot