Skip to content

Fix ir_metadata Python frames func and remove dead code #74979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wconstab wants to merge 2 commits into from
Closed

Fix ir_metadata Python frames func and remove dead code #74979

wconstab wants to merge 2 commits into from

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Mar 30, 2022

No description provided.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 5d654cd (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2022

@wconstab has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@wconstab wconstab mentioned this pull request Mar 30, 2022
Merged
JackCaoG
JackCaoG approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@JackCaoG JackCaoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2022

@wconstab has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@wconstab wconstab force-pushed the wconstab/frameinfo branch from 4ba1398 to 5d654cd Compare March 31, 2022 16:44
alanwaketan
alanwaketan approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@alanwaketan alanwaketan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

facebook-github-bot pushed a commit that referenced this pull request Mar 31, 2022
@wconstab @facebook-github-bot
Fix ir_metadata Python frames func and remove dead code (#74979)
fc6c0a1 
Summary: Pull Request resolved: #74979

Reviewed By: alanwaketan

Differential Revision: D35261641

Pulled By: wconstab

fbshipit-source-id: e82b5f17d0043c4a3de72c16fb42fd02a85414fe
@github-actions
Copy link
Contributor

github-actions bot commented Mar 31, 2022

Hey @wconstab.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@wconstab wconstab added release notes: lazy release notes category topic: not user facing topic category labels Mar 31, 2022
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
@github-actions github-actions bot deleted the wconstab/frameinfo branch February 15, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alanwaketan alanwaketan alanwaketan approved these changes

@JackCaoG JackCaoG JackCaoG approved these changes

Assignees

No one assigned

Labels

cla signed release notes: lazy release notes category topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wconstab @facebook-github-bot @alanwaketan @JackCaoG