Skip to content

[testing] Update dispatch macros #74977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malfet merged 1 commit into from
Mar 30, 2022
Merged

[testing] Update dispatch macros #74977

malfet merged 1 commit into from
Mar 30, 2022

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Mar 30, 2022 •
edited
Loading

Hi,
This PR is the follow-up PR of #71561. (the previous PR had a couple of merge conflicts and was reverted, this PR resolves that).
Please take a look. Thanks!

cc: @pmeier @mruberry @kshitij12345

@khushi-411 @malfet
[testing] Update dispatch macros
0ef8fea 
Hi,
This PR is the follow-up PR of #71561. (the previous PR had a couple of merge conflicts and was reverted, this PR resolves that).
Please take a look. Thanks!

cc: @pmeier @mruberry @kshitij12345
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 0ef8fea (more details on the Dr. CI page):

  • 4/4 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7 / build (1/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T20:06:07.6424404Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m 
2022-03-30T20:06:07.6421307Z �[36;1mfi�[0m
2022-03-30T20:06:07.6421533Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-30T20:06:07.6421875Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-30T20:06:07.6422196Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-30T20:06:07.6422522Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-30T20:06:07.6422800Z �[36;1m  exit 1�[0m
2022-03-30T20:06:07.6423099Z �[36;1mfi�[0m
2022-03-30T20:06:07.6423355Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-30T20:06:07.6423686Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-30T20:06:07.6424074Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-30T20:06:07.6424404Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-30T20:06:07.6424734Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-30T20:06:07.6425029Z �[36;1m  exit 1�[0m
2022-03-30T20:06:07.6425195Z �[36;1mfi�[0m
2022-03-30T20:06:07.6425381Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-30T20:06:07.6435664Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-30T20:06:07.6435882Z env:
2022-03-30T20:06:07.6436025Z   IN_CI: 1
2022-03-30T20:06:07.6436187Z   IS_GHA: 1
2022-03-30T20:06:07.6436402Z   BASE_REVISION: cc23725e89713138aa1c81ce5fb4a8dbcd440ccf
2022-03-30T20:06:07.6436817Z   DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7:a2c09c6009bb8a10cbb45a8c5f7c573593289be0

See GitHub Actions build pull / linux-xenial-cuda11.3-py3.7-gcc7-bazel-test / build-and-test (2/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T20:06:02.4347119Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m 
2022-03-30T20:06:02.4343954Z �[36;1mfi�[0m
2022-03-30T20:06:02.4344404Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-30T20:06:02.4344841Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-30T20:06:02.4345154Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-30T20:06:02.4345495Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-30T20:06:02.4345775Z �[36;1m  exit 1�[0m
2022-03-30T20:06:02.4345940Z �[36;1mfi�[0m
2022-03-30T20:06:02.4346161Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-30T20:06:02.4346489Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-30T20:06:02.4346794Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-30T20:06:02.4347119Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-30T20:06:02.4347534Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-30T20:06:02.4347769Z �[36;1m  exit 1�[0m
2022-03-30T20:06:02.4347934Z �[36;1mfi�[0m
2022-03-30T20:06:02.4348117Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-30T20:06:02.4358286Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-30T20:06:02.4358502Z env:
2022-03-30T20:06:02.4358646Z   IN_CI: 1
2022-03-30T20:06:02.4358804Z   IS_GHA: 1
2022-03-30T20:06:02.4358980Z   GIT_DEFAULT_BRANCH: master
2022-03-30T20:06:02.4359204Z   BASE_REVISION: cc23725e89713138aa1c81ce5fb4a8dbcd440ccf

See GitHub Actions build pull / deploy-linux-xenial-cuda11.3-py3.7-gcc7 / build (3/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

2022-03-30T20:06:11.6076542Z �[36;1m echo "ERR...t available for the merge-base of your branch"�[0m 
2022-03-30T20:06:11.6073563Z �[36;1mfi�[0m
2022-03-30T20:06:11.6073810Z �[36;1m# Covers the case where a previous tag doesn't exist for the tree�[0m
2022-03-30T20:06:11.6074163Z �[36;1m# this is only really applicable on trees that don't have `.circleci/docker` at its merge base, i.e. nightly�[0m
2022-03-30T20:06:11.6074487Z �[36;1mif ! git rev-parse "$MERGE_BASE:.circleci/docker"; then�[0m
2022-03-30T20:06:11.6074843Z �[36;1m  echo "Directory '.circleci/docker' not found in commit $MERGE_BASE, you should probably rebase onto a more recent commit"�[0m
2022-03-30T20:06:11.6075139Z �[36;1m  exit 1�[0m
2022-03-30T20:06:11.6075310Z �[36;1mfi�[0m
2022-03-30T20:06:11.6075538Z �[36;1mPREVIOUS_DOCKER_TAG=$(git rev-parse "$MERGE_BASE:.circleci/docker")�[0m
2022-03-30T20:06:11.6075881Z �[36;1m# If no image exists but the hash is the same as the previous hash then we should error out here�[0m
2022-03-30T20:06:11.6076200Z �[36;1mif [[ "${PREVIOUS_DOCKER_TAG}" = "${DOCKER_TAG}" ]]; then�[0m
2022-03-30T20:06:11.6076542Z �[36;1m  echo "ERROR: Something has gone wrong and the previous image isn't available for the merge-base of your branch"�[0m
2022-03-30T20:06:11.6076949Z �[36;1m  echo "       contact the PyTorch team to restore the original images"�[0m
2022-03-30T20:06:11.6077245Z �[36;1m  exit 1�[0m
2022-03-30T20:06:11.6077418Z �[36;1mfi�[0m
2022-03-30T20:06:11.6077611Z �[36;1mecho ::set-output name=rebuild::yes�[0m
2022-03-30T20:06:11.6088188Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-30T20:06:11.6088412Z env:
2022-03-30T20:06:11.6088563Z   IN_CI: 1
2022-03-30T20:06:11.6088730Z   IS_GHA: 1
2022-03-30T20:06:11.6088956Z   BASE_REVISION: cc23725e89713138aa1c81ce5fb4a8dbcd440ccf
2022-03-30T20:06:11.6089379Z   DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/pytorch-linux-xenial-cuda11.3-cudnn8-py3-gcc7:a2c09c6009bb8a10cbb45a8c5f7c573593289be0

1 failure not recognized by patterns:

Job Step Action
GitHub Actions pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) Test 🔁 rerun
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@lezcano lezcano removed their request for review March 30, 2022 20:04
@malfet malfet mentioned this pull request Mar 30, 2022
Closed
@malfet
Copy link
Contributor Author

malfet commented Mar 30, 2022 •
edited
Loading

Plan to merge it in order to preserve original authorship

@malfet malfet merged commit bfac65d into master Mar 30, 2022
@malfet malfet deleted the malfet/reland-74289 branch March 30, 2022 21:13
@khushi-411
Copy link
Contributor

khushi-411 commented Mar 31, 2022

Hi, @malfet!
Thank you so much for relanding this PR! I'm so happy to see it :)

facebook-github-bot pushed a commit that referenced this pull request Mar 31, 2022
@malfet @khushi-411 @facebook-github-bot
[testing] Update dispatch macros (#74977)
cb59c8c 
Summary:
This PR is reland of #74289

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/bfac65dfe56dba1f16824a91ab1410a90ffe5489

Reviewed By: atalman

Differential Revision: D35284139

Pulled By: malfet

fbshipit-source-id: 911da04270611b47b55e148135a3346a02f05c71

Co-authored-by: Khushi Agrawal <khushiagrawal411@gmail.com>
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@nikitaved nikitaved Awaiting requested review from nikitaved

@IvanYashchuk IvanYashchuk Awaiting requested review from IvanYashchuk

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@malfet @facebook-github-bot @khushi-411 @atalman