Make all .pyi.in files exportable from torch/_C/ folder
#74962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit b80bc11 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35255502 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35255502 |
malfet
force-pushed
the
export-D35255502
branch
from
ee6e623 to
b73972e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35255502 |
malfet
force-pushed
the
export-D35255502
branch
from
b73972e to
7f4d890
Compare
) Summary: Pull Request resolved: pytorch#74962 This would eliminate the need for build system changes when new .pyi.in files is added Test Plan: CI Reviewed By: seemethere Differential Revision: D35255502 fbshipit-source-id: e73341c4e17df8825e50f20a3c7d7a0252e757f9
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D35255502 |
malfet
force-pushed
the
export-D35255502
branch
from
7f4d890 to
b80bc11
Compare
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 31, 2022
Summary: Pull Request resolved: #74962 This would eliminate the need for build system changes when new .pyi.in files is added Test Plan: CI Reviewed By: seemethere Differential Revision: D35255502 fbshipit-source-id: 9aa84d2fc0f7933293cac4c6588da72a9d649df0
Collaborator
|
Should the OSS bazel build also rely on this file? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This would eliminate the need for build system changes when new .pyi.in files is added
Test Plan: CI
Reviewed By: seemethere
Differential Revision: D35255502