Skip to content

[jiterator] sigmoid_backward: complex #74948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
khushi-411 wants to merge 5 commits into from
Closed

[jiterator] sigmoid_backward: complex #74948

khushi-411 wants to merge 5 commits into from

Conversation

@khushi-411
Copy link
Contributor

@khushi-411 khushi-411 commented Mar 30, 2022 •
edited
Loading

Follows: #74748

cc @kshitij12345!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 30, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 7f8c74a (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@khushi-411 khushi-411 marked this pull request as draft March 30, 2022 07:37
@khushi-411 khushi-411 marked this pull request as ready for review March 30, 2022 09:59
@kshitij12345
Copy link
Collaborator

kshitij12345 commented Mar 30, 2022

Failure looks real : https://github.com/pytorch/pytorch/runs/5750326823?check_suite_focus=true#step:9:11346

@dagitses dagitses requested a review from ngimel April 1, 2022 14:40
@dagitses dagitses added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 1, 2022
@khushi-411 khushi-411 requested a review from kshitij12345 April 4, 2022 18:55
kshitij12345
kshitij12345 approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @khushi-411

cc: @ngimel

@ngimel
Copy link
Collaborator

ngimel commented Apr 6, 2022

@pytorchbot merge this please

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Apr 6, 2022

Merge failed due to Command git -C /home/runner/work/pytorch/pytorch push origin master returned non-zero exit code 1
To https://github.com/pytorch/pytorch
! [rejected] master -> master (non-fast-forward)
error: failed to push some refs to 'https://github.com/pytorch/pytorch'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Raised by https://github.com/pytorch/pytorch/actions/runs/2104972689

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 6, 2022

@ngimel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Apr 7, 2022
@khushi-411 @facebook-github-bot
[jiterator] sigmoid_backward: complex (#74948)
7883b8d 
Summary:
Follows: #74748

cc kshitij12345!

Pull Request resolved: #74948

Reviewed By: malfet

Differential Revision: D35445949

Pulled By: ngimel

fbshipit-source-id: acd921a210fd15cc78046e37532173162daa38b8
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

Hey @khushi-411.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@khushi-411
Copy link
Contributor Author

khushi-411 commented Apr 7, 2022

Hi, @kshitij12345! Hi, @ngimel!
Thanks for reviewing the PR!! :)

@khushi-411 khushi-411 deleted the jiterator/sigmoid_backward branch April 7, 2022 06:27
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@kshitij12345 kshitij12345 kshitij12345 approved these changes

Assignees

@ngimel ngimel

Labels

cla signed module: jiterator open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@khushi-411 @facebook-github-bot @kshitij12345 @ngimel @pytorchmergebot @dagitses @pytorchbot