[FSDP] Warning when fail to clone #74946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn instead of hard failure when fail to clone state_dict, as this param might not be managed by FSDP and thus we do not expect to clone it. Differential Revision: [D35242306](https://our.internmc.facebook.com/intern/diff/D35242306/) [ghstack-poisoned]
rohan-varma
requested review from
H-Huang,
awgu,
mingzhe09088,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1bc5619 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
rohan-varma
added a commit
that referenced
this pull request
Mar 30, 2022
Warn instead of hard failure when fail to clone state_dict, as this param might not be managed by FSDP and thus we do not expect to clone it. Differential Revision: [D35242306](https://our.internmc.facebook.com/intern/diff/D35242306/) ghstack-source-id: 152557257 Pull Request resolved: #74946
mrshenli
approved these changes
Mar 30, 2022
Warn instead of hard failure when fail to clone state_dict, as this param might not be managed by FSDP and thus we do not expect to clone it. Differential Revision: [D35242306](https://our.internmc.facebook.com/intern/diff/D35242306/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Mar 31, 2022
Pull Request resolved: #74946 Warn instead of hard failure when fail to clone state_dict, as this param might not be managed by FSDP and thus we do not expect to clone it. ghstack-source-id: 152653316 Differential Revision: [D35242306](https://our.internmc.facebook.com/intern/diff/D35242306/)
Warn instead of hard failure when fail to clone state_dict, as this param might not be managed by FSDP and thus we do not expect to clone it. Differential Revision: [D35242306](https://our.internmc.facebook.com/intern/diff/D35242306/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 4, 2022
Pull Request resolved: #74946 Warn instead of hard failure when fail to clone state_dict, as this param might not be managed by FSDP and thus we do not expect to clone it. ghstack-source-id: 152933958 Differential Revision: [D35242306](https://our.internmc.facebook.com/intern/diff/D35242306/)
Warn instead of hard failure when fail to clone state_dict, as this param might not be managed by FSDP and thus we do not expect to clone it. Differential Revision: [D35242306](https://our.internmc.facebook.com/intern/diff/D35242306/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Apr 4, 2022
Pull Request resolved: #74946 Warn instead of hard failure when fail to clone state_dict, as this param might not be managed by FSDP and thus we do not expect to clone it. ghstack-source-id: 152978204 Differential Revision: [D35242306](https://our.internmc.facebook.com/intern/diff/D35242306/)
Member
|
Can we merge this with GHF when it's ready? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 5, 2022
Summary: Pull Request resolved: #74946 Warn instead of hard failure when fail to clone state_dict, as this param might not be managed by FSDP and thus we do not expect to clone it. ghstack-source-id: 152978204 Test Plan: CI Reviewed By: mrshenli Differential Revision: D35242306 fbshipit-source-id: d9eb58a2993341040e4a9f36fa388f423bd2ddc5
Contributor
|
Hey @rohan-varma. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Warn instead of hard failure when fail to clone state_dict, as this
param might not be managed by FSDP and thus we do not expect to clone it.
Differential Revision: D35242306