[pkg] add zipfile unit tests #74929

PaliC · 2022-03-29T21:31:15Z

Stack from ghstack (oldest at bottom):

Add unit tests for zipfile classes

[ghstack-poisoned]

facebook-github-bot · 2022-03-29T21:31:20Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/74929
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
❓Need help or want to give feedback on the CI? Visit our office hours

💊 CI failures summary and remediations

As of commit 3e99b19 (more details on the Dr. CI page):

2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-04-07T16:47:36.4949505Z The PR is introduc...m to confirm whether this change is wanted or not.

2022-04-07T16:47:36.4937913Z processing existing schema:  text(__torch__.torch.classes.profiling.SourceRef _0) -> (str _0)
2022-04-07T16:47:36.4938976Z processing existing schema:  count(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-04-07T16:47:36.4940372Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> (int _0)
2022-04-07T16:47:36.4941588Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> (__torch__.torch.classes.profiling.SourceRef _0)
2022-04-07T16:47:36.4943297Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> (Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0)
2022-04-07T16:47:36.4944258Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-04-07T16:47:36.4945239Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-04-07T16:47:36.4946241Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> (NoneType _0)
2022-04-07T16:47:36.4947910Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> (__torch__.torch.classes.profiling.SourceStats[] _0)
2022-04-07T16:47:36.4948927Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (NoneType _0)
2022-04-07T16:47:36.4949505Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-04-07T16:47:36.4949519Z 
2022-04-07T16:47:36.4949643Z Broken ops: [
2022-04-07T16:47:36.4949964Z 	aten::scatter_reduce_.two(Tensor(a!) self, int dim, Tensor index, Tensor src, str reduce, *, bool include_self=True) -> (Tensor(a!))
2022-04-07T16:47:36.4950025Z ]
2022-04-07T16:47:36.5859301Z + cleanup
2022-04-07T16:47:36.5859421Z + retcode=1
2022-04-07T16:47:36.5859552Z + set +x
2022-04-07T16:47:36.5898404Z ##[error]Process completed with exit code 1.
2022-04-07T16:47:36.5945496Z Prepare all required actions
2022-04-07T16:47:36.5945704Z Getting action download info

pull / linux-xenial-py3.7-clang7-asan / test (default, 2, 3, linux.2xlarge) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-04-07T16:47:54.2277938Z SUMMARY: Undefined.../jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in

2022-04-07T16:47:54.1752904Z     #10 0x560fec7bcc81 in run_mod /home/builder/tkoch/workspace/python_1648536129212/work/Python/pythonrun.c:1037
2022-04-07T16:47:54.1753612Z     #11 0x560fec7c7c69 in PyRun_StringFlags /home/builder/tkoch/workspace/python_1648536129212/work/Python/pythonrun.c:961
2022-04-07T16:47:54.1754510Z     #12 0x560fec7c7ccb in PyRun_SimpleStringFlags /home/builder/tkoch/workspace/python_1648536129212/work/Python/pythonrun.c:455
2022-04-07T16:47:54.1755567Z     #13 0x560fec7c7dc8 in pymain_run_command /home/builder/tkoch/workspace/python_1648536129212/work/Modules/main.c:420
2022-04-07T16:47:54.1756550Z     #14 0x560fec7c7dc8 in pymain_run_python /home/builder/tkoch/workspace/python_1648536129212/work/Modules/main.c:2907
2022-04-07T16:47:54.1757004Z     #15 0x560fec7c7dc8 in pymain_main /home/builder/tkoch/workspace/python_1648536129212/work/Modules/main.c:3460
2022-04-07T16:47:54.1757934Z     #16 0x560fec7c818b in _Py_UnixMain /home/builder/tkoch/workspace/python_1648536129212/work/Modules/main.c:3495
2022-04-07T16:47:54.2277033Z     #17 0x7fa7f4d3d83f in __libc_start_main /build/glibc-S7Ft5T/glibc-2.23/csu/../csu/libc-start.c:291
2022-04-07T16:47:54.2277431Z     #18 0x560fec76d039 in _start (/opt/conda/bin/python3.7+0x1d8039)
2022-04-07T16:47:54.2277613Z 
2022-04-07T16:47:54.2277938Z SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /var/lib/jenkins/workspace/aten/src/ATen/Utils.cpp:20:3 in 
2022-04-07T16:47:54.2504121Z + retcode=1
2022-04-07T16:47:54.2504540Z + set -e
2022-04-07T16:47:54.2504799Z + return 1
2022-04-07T16:47:54.2508193Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX-* ]]
2022-04-07T16:47:54.2508736Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X ]]
2022-04-07T16:47:54.2509370Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX2-* ]]
2022-04-07T16:47:54.2509842Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X\2 ]]
2022-04-07T16:47:54.2510469Z + [[ linux-xenial-py3.7-clang7-asan-default == *-NO_AVX512-* ]]
2022-04-07T16:47:54.2510980Z + [[ default == \n\o\g\p\u\_\N\O\_\A\V\X\5\1\2 ]]
2022-04-07T16:47:54.2513255Z + [[ linux-xenial-py3.7-clang7-asan-default == *tbb* ]]

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

d4l3k · 2022-03-29T21:47:11Z

lint is failing otherwise looks good

d4l3k · 2022-03-29T21:48:17Z

test/package/test_zipfile.py

+    def __init__(self, *args, **kwargs):
+        super().__init__(*args, **kwargs)
+        self.ZipfileWriter = TorchScriptPackageZipFileWriter
+        self.ZipfileReader = TorchScriptPackageZipFileReader


should this be using TorchScript one or the not torchscript one?

Add unit tests for zipfile classes [ghstack-poisoned]

ghstack-source-id: dfe6eed Pull Request resolved: #74929

Add unit tests for zipfile classes [ghstack-poisoned]

ghstack-source-id: 30d7aa3 Pull Request resolved: #74929

PaliC · 2022-03-30T17:09:52Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

PaliC · 2022-04-01T23:57:44Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

PaliC · 2022-04-02T00:39:39Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

PaliC · 2022-04-02T01:05:11Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

ghstack-source-id: 67339f7 Pull Request resolved: #74929

PaliC · 2022-04-02T01:11:22Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

PaliC · 2022-04-04T16:13:35Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

PaliC · 2022-04-05T01:01:06Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

d4l3k

reapproving

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

ghstack-source-id: 0e946ca Pull Request resolved: #74929

PaliC · 2022-04-05T20:42:08Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Pull Request resolved: #74929 Add unit tests for zipfile classes Test Plan: Imported from OSS Reviewed By: dagitses, d4l3k Differential Revision: D35254715 Pulled By: PaliC fbshipit-source-id: bda862cc6df823249f577e37a2718247e9d0a431

github-actions · 2022-04-05T23:42:03Z

Hey @PaliC.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot · 2022-04-06T05:52:48Z

This pull request has been reverted by 20266f0. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

PaliC · 2022-04-06T05:56:08Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

PaliC · 2022-04-06T06:05:24Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

PaliC · 2022-04-06T15:11:36Z

@PaliC has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Pull Request resolved: #74929 Add unit tests for zipfile classes Test Plan: Imported from OSS Reviewed By: d4l3k Differential Revision: D35423078 Pulled By: PaliC fbshipit-source-id: 13cd0f82ec7d9fc95b6db86b65b9958e389086e3

facebook-github-bot · 2022-04-07T13:33:59Z

This pull request has been reverted by a1d59bb. To re-land this change, please open another pull request, assignthe same reviewers, fix the CI failures that caused the revert and make sure that the failing CI runs on the PR by applying the proper ciflow label (e.g., ciflow/trunk).

Summary: This PR is a response to pytorch#72237 and pytorch#74929 getting reverted as they were breaking MacOS testing builds due to the lack of the `zipfile` package. It does effectively the same thing. However, it also installs `zipfile` to MacOS builds in `.jenkins/pytorch/macos-common.sh` Test Plan: External CI Differential Revision: D35474261 fbshipit-source-id: 68a8203e12422ea394f1c597ea432d347ee6e48c

Summary: This PR is a response to pytorch#72237 and pytorch#74929 getting reverted as they were breaking MacOS testing builds due to the lack of the `zipfile` package. It does effectively the same thing. However, it also installs `zipfile` to MacOS builds in `.jenkins/pytorch/macos-common.sh` Test Plan: External CI Differential Revision: D35474261 fbshipit-source-id: 0098fa87753293fc627ba4a95c5e03e8d14cf481

Summary: This PR is a response to pytorch#72237 and pytorch#74929 getting reverted as they were breaking MacOS testing builds due to the lack of the `zipfile` package. It does effectively the same thing. However, it also installs `zipfile` to MacOS builds in `.jenkins/pytorch/macos-common.sh` Test Plan: External CI Differential Revision: D35474261 fbshipit-source-id: 02687b7b690b1e9d922578b5c78f68f1cc323972

[pkg] add zipfile unit tests

3ce01d1

[ghstack-poisoned]

This was referenced Mar 29, 2022

[pkg] add generic ZipFile Reader/Writer #72237

Closed

remove need for torch in torch.package #72961

Closed

facebook-github-bot added the cla signed label Mar 29, 2022

PaliC requested a review from d4l3k March 29, 2022 21:31

d4l3k approved these changes Mar 29, 2022

View reviewed changes

d4l3k reviewed Mar 29, 2022

View reviewed changes

Update on "[pkg] add zipfile unit tests"

c4609eb

Add unit tests for zipfile classes [ghstack-poisoned]

PaliC added a commit that referenced this pull request Mar 29, 2022

[pkg] add zipfile unit tests

3b08acb

ghstack-source-id: dfe6eed Pull Request resolved: #74929

Update on "[pkg] add zipfile unit tests"

7f0b2b0

Add unit tests for zipfile classes [ghstack-poisoned]

PaliC added a commit that referenced this pull request Mar 30, 2022

[pkg] add zipfile unit tests

6599aeb

ghstack-source-id: 30d7aa3 Pull Request resolved: #74929

Update on "[pkg] add zipfile unit tests"

dfccb13

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

Update on "[pkg] add zipfile unit tests"

bb859f4

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

Update on "[pkg] add zipfile unit tests"

3724310

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

Update on "[pkg] add zipfile unit tests"

bca9019

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

PaliC added a commit that referenced this pull request Apr 2, 2022

[pkg] add zipfile unit tests

8c6adc0

ghstack-source-id: 67339f7 Pull Request resolved: #74929

Update on "[pkg] add zipfile unit tests"

3ded38e

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

PaliC requested a review from d4l3k April 5, 2022 20:04

d4l3k approved these changes Apr 5, 2022

View reviewed changes

Update on "[pkg] add zipfile unit tests"

3e99b19

Add unit tests for zipfile classes Differential Revision: [D35254715](https://our.internmc.facebook.com/intern/diff/D35254715) [ghstack-poisoned]

PaliC added a commit that referenced this pull request Apr 5, 2022

[pkg] add zipfile unit tests

8491e5c

ghstack-source-id: 0e946ca Pull Request resolved: #74929

pytorchmergebot closed this in 93e650b Apr 5, 2022

PaliC reopened this Apr 6, 2022

facebook-github-bot added the Reverted label Apr 6, 2022

malfet closed this in 99ce996 Apr 6, 2022

PaliC reopened this Apr 7, 2022

PaliC closed this Apr 7, 2022

This was referenced Apr 7, 2022

[pkg] Create a torchless version of torch.package #75441

Closed

Add zipfile to MacOS tests #75448

Closed

facebook-github-bot deleted the gh/PaliC/152/head branch April 11, 2022 14:17

WBobby mentioned this pull request Aug 17, 2022

Add ROCm5.2.3/AMDGPU support for PyTorch WBobby/pytorch#2

Closed

[pkg] add zipfile unit tests #74929

[pkg] add zipfile unit tests #74929

Uh oh!

Conversation

PaliC commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

🕵️ 2 new failures recognized by patterns

pull / linux-xenial-py3.7-gcc5.4 / test (backwards_compat, 1, 1, linux.2xlarge) (1/2)

pull / linux-xenial-py3.7-clang7-asan / test (default, 2, 3, linux.2xlarge) (2/2)

Uh oh!

d4l3k commented Mar 29, 2022

Uh oh!

d4l3k Mar 29, 2022

Choose a reason for hiding this comment

Uh oh!

PaliC commented Mar 30, 2022

Uh oh!

PaliC commented Apr 1, 2022

Uh oh!

PaliC commented Apr 2, 2022

Uh oh!

PaliC commented Apr 2, 2022

Uh oh!

PaliC commented Apr 2, 2022

Uh oh!

PaliC commented Apr 4, 2022

Uh oh!

PaliC commented Apr 5, 2022

Uh oh!

d4l3k left a comment

Choose a reason for hiding this comment

Uh oh!

PaliC commented Apr 5, 2022

Uh oh!

github-actions bot commented Apr 5, 2022

Uh oh!

facebook-github-bot commented Apr 6, 2022

Uh oh!

PaliC commented Apr 6, 2022

Uh oh!

PaliC commented Apr 6, 2022

Uh oh!

PaliC commented Apr 6, 2022

Uh oh!

facebook-github-bot commented Apr 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PaliC commented Mar 29, 2022 •

edited

Loading

facebook-github-bot commented Mar 29, 2022 •

edited

Loading