Add sparse gradient option to pretrained embedding #7492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borguz
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
soumith
reviewed
May 11, 2018
|
|
||
| @classmethod | ||
| def from_pretrained(cls, embeddings, freeze=True): | ||
| def from_pretrained(cls, embeddings, freeze=True, sparse=False): |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
reviewed
May 11, 2018
torch/nn/utils/clip_grad.py
Outdated
| if clip_coef < 1: | ||
| for p in parameters: | ||
| p.grad.data.mul_(clip_coef.item()) | ||
| p.grad.data.mul_(float(clip_coef)) |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
approved these changes
May 11, 2018
onnxbot
added a commit
to onnxbot/onnx-fb-universe
that referenced
this pull request
May 11, 2018
weiyangfb
pushed a commit
to weiyangfb/pytorch
that referenced
this pull request
Jun 11, 2018
* Add sparse gradient option to pretrained embedding * Add sparse gradient option to pretrained embedding * Trailing white space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited clip_grad so that it works with a mix of sparse and dense tensors.
Added sparse argument to pre-trained embedding loading.