Skip to content

More folders in clang-tidy #74908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shahofblah wants to merge 1 commit into from
Closed

More folders in clang-tidy #74908

shahofblah wants to merge 1 commit into from

Conversation

@shahofblah
Copy link
Contributor

@shahofblah shahofblah commented Mar 29, 2022

  1. Added folders torch/csrc/onnx and torch/csrc/cuda to clang-tidy.
  2. Fixed clang-tidy violations in torch/csrc/cuda
  3. Fixed(added Python import paths) in clang-tidy Python runner

Fixes some of #62011

@shahofblah
1. Added folders torch/csrc/onnx and torch/csrc/cuda to clang-tidy.
26769d9 
2. Fixed clang-tidy violations in torch/csrc/cuda
3. Fixed(added Python import paths) in clang-tidy Python runner
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 29, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 26769d9 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

atalman
atalman approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman
Copy link
Contributor

atalman commented Mar 29, 2022

@pytorchbot merge this

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 29, 2022

Merge failed due to PR 74908 does not match merge rules
Raised by https://github.com/pytorch/pytorch/actions/runs/2060090793

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 29, 2022

@shahofblah has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Mar 29, 2022
@shahofblah @facebook-github-bot
More folders in clang-tidy (#74908)
830186a 
Summary:
1. Added folders torch/csrc/onnx and torch/csrc/cuda to clang-tidy.
2. Fixed clang-tidy violations in torch/csrc/cuda
3. Fixed(added Python import paths) in clang-tidy Python runner

Fixes some of #62011

Pull Request resolved: #74908

Reviewed By: atalman

Differential Revision: D35221843

Pulled By: shahofblah

fbshipit-source-id: f0d1f066550b383aa48449b12d194009977c0bd8
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022

Hey @shahofblah.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
@github-actions github-actions bot deleted the gh/shahofblah/5/base branch February 15, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@seemethere seemethere Awaiting requested review from seemethere

@janeyx99 janeyx99 Awaiting requested review from janeyx99

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shahofblah @facebook-github-bot @atalman @pytorchmergebot