Skip to content

[FX] Fix type of argument min_acc_module_size #74891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cgufb wants to merge 1 commit into from
Closed

[FX] Fix type of argument min_acc_module_size #74891

cgufb wants to merge 1 commit into from

Conversation

@cgufb
Copy link
Contributor

@cgufb cgufb commented Mar 29, 2022

Summary:
As title, otherwise the below error is thrown:

TypeError: '>=' not supported between instances of 'int' and 'str'

Test Plan: easy

Differential Revision: D35206473

@cgufb @facebook-github-bot
[FX] Fix type of argument min_acc_module_size
750174a 
Summary:
As title, otherwise the below error is thrown:
```
TypeError: '>=' not supported between instances of 'int' and 'str'
```

Test Plan: easy

Differential Revision: D35206473

fbshipit-source-id: f88bb0b0c314c3228d7dc3bbb7b2626692a77f58
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 29, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 750174a (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 29, 2022

This pull request was exported from Phabricator. Differential Revision: D35206473

facebook-github-bot pushed a commit that referenced this pull request Mar 29, 2022
@cgufb @facebook-github-bot
[FX] Fix type of argument min_acc_module_size (#74891)
20744d2 
Summary:
Pull Request resolved: #74891

As title, otherwise the below error is thrown:
```
TypeError: '>=' not supported between instances of 'int' and 'str'
```

Test Plan: easy

Reviewed By: jackm321

Differential Revision: D35206473

fbshipit-source-id: 200c83b9a19b6aae6f0da03abe99121e55893fd3
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022

Hey @cgufb.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed fb-exported module: fx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cgufb @facebook-github-bot