Skip to content

[FSDP] exclude from typing #74833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rohan-varma wants to merge 1 commit into from
Closed

[FSDP] exclude from typing #74833

rohan-varma wants to merge 1 commit into from

Conversation

@rohan-varma
Copy link
Contributor

@rohan-varma rohan-varma commented Mar 28, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

FSDP has 74 type ignores and more being added, it may be better to
exclude from typechecking until we can type it properly.

Differential Revision: D35186441

@rohan-varma
[FSDP] exclude from typing
55ce756 
FSDP has 74 type ignores and more being added, it may be better to
exclude from typechecking until we can type it properly.

Differential Revision: [D35186441](https://our.internmc.facebook.com/intern/diff/D35186441/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 28, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 55ce756 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@rohan-varma rohan-varma mentioned this pull request Mar 28, 2022
Closed
18 tasks
@kumpera
Copy link
Contributor

kumpera commented Mar 28, 2022

Could we convert this into a set of bootcamp tasks?

@rohan-varma
Copy link
Contributor Author

rohan-varma commented Mar 28, 2022

@kumpera Some of it may be bootcampable, although the main issue is that mypy has trouble supporting attributes such as p._full_param_padded that are set outside of the constructor.

facebook-github-bot pushed a commit that referenced this pull request Mar 29, 2022
@rohan-varma @facebook-github-bot
[FSDP] exclude from typing (#74833)
4b410e1 
Summary:
Pull Request resolved: #74833

FSDP has 74 type ignores and more being added, it may be better to
exclude from typechecking until we can type it properly.
ghstack-source-id: 152354450

Test Plan: CI

Reviewed By: zhaojuanmao

Differential Revision: D35186441

fbshipit-source-id: d06d90a06dcdbd38033adc70d0e9374333d4dc9a
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2022

Hey @rohan-varma.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@facebook-github-bot facebook-github-bot deleted the gh/rohan-varma/528/head branch April 1, 2022 14:17
@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhaojuanmao zhaojuanmao zhaojuanmao approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rohan-varma @facebook-github-bot @kumpera @zhaojuanmao