Skip to content

[Model Averaging] Remove unused variable world_size in post_localSGD_hook.py #74803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wayi1 wants to merge 1 commit into from
Closed

[Model Averaging] Remove unused variable world_size in post_localSGD_hook.py #74803

wayi1 wants to merge 1 commit into from

Conversation

@wayi1
Copy link
Contributor

@wayi1 wayi1 commented Mar 26, 2022

As title

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 26, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit fb23ce8 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Mar 26, 2022
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 28, 2022

@mrshenli has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Mar 28, 2022
@wayi1 @facebook-github-bot
[Model Averaging] Remove unused variable world_size in post_localSGD_…
033efb2 
…hook.py (#74803)

Summary:
As title

Pull Request resolved: #74803

Reviewed By: albanD

Differential Revision: D35175613

Pulled By: mrshenli

fbshipit-source-id: 881933656ed214554b8acb4c5756349cea0af51d
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2022

Hey @wayi1.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@WBobby WBobby mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@mingzhe09088 mingzhe09088 Awaiting requested review from mingzhe09088

@H-Huang H-Huang Awaiting requested review from H-Huang

Assignees

No one assigned

Labels

cla signed oncall: distributed Add this issue/PR to distributed oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wayi1 @facebook-github-bot @mrshenli @pytorchbot