[quant][fx] Remove input_output_observed from BinaryOpQuantizeHandler #74776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: when both inputs are scalars, fx tracing will directly calculate the result, instead of generating an op in the fx graph so num_tensor_args will always be greater than 1 for binary ops, so the input_output_observed will always return True for BinaryQuantizeHandler We will remove input_output_observed method after dynamic quantization in qconfig is properly supported Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Mar 25, 2022
Summary: when both inputs are scalars, fx tracing will directly calculate the result, instead of generating an op in the fx graph so num_tensor_args will always be greater than 1 for binary ops, so the input_output_observed will always return True for BinaryQuantizeHandler We will remove input_output_observed method after dynamic quantization in qconfig is properly supported Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 814441c Pull Request resolved: #74776
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit c6c16d1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
Author
|
@jerryzh168 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
jerryzh168
requested review from
andrewor14 and
vkuzo
and removed request for
vkuzo
vkuzo
approved these changes
Mar 28, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2022
…#74776) Summary: Pull Request resolved: #74776 when both inputs are scalars, fx tracing will directly calculate the result, instead of generating an op in the fx graph so num_tensor_args will always be greater than 1 for binary ops, so the input_output_observed will always return True for BinaryQuantizeHandler We will remove input_output_observed method after dynamic quantization in qconfig is properly supported Test Plan: python test/test_quantization.py TestQuantizeFx python test/test_quantization.py TestQuantizeFxOps Imported from OSS Reviewed By: albanD Differential Revision: D35153531 fbshipit-source-id: fa777429eeb64a6a78a98f8d8dcd9e0903c8b209
Contributor
|
Hey @jerryzh168. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
when both inputs are scalars, fx tracing will directly calculate the result, instead of generating an op in the fx graph
so num_tensor_args will always be greater than 1 for binary ops, so the input_output_observed will always return True
for BinaryQuantizeHandler
We will remove input_output_observed method after dynamic quantization in qconfig is properly supported
Test Plan:
python test/test_quantization.py TestQuantizeFx
python test/test_quantization.py TestQuantizeFxOps
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D35153531